From owner-cvs-all@FreeBSD.ORG Thu Jun 26 20:25:44 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 91C3837B401; Thu, 26 Jun 2003 20:25:44 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4116743FF3; Thu, 26 Jun 2003 20:25:44 -0700 (PDT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h5R3Pi0U053230; Thu, 26 Jun 2003 20:25:44 -0700 (PDT) (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h5R3PhqO053229; Thu, 26 Jun 2003 20:25:43 -0700 (PDT) Message-Id: <200306270325.h5R3PhqO053229@repoman.freebsd.org> From: Warner Losh Date: Thu, 26 Jun 2003 20:25:43 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/ata ata-card.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jun 2003 03:25:45 -0000 imp 2003/06/26 20:25:43 PDT FreeBSD src repository Modified files: sys/dev/ata ata-card.c Log: Remove check to see if the get resource for the second resource succeeds. There is a difference between how OLDCARD and NEWCARD deal with their resources, and this code exposes that difference. I'm not sure which behavior is correct, and will need to look into that in more detail. However, it appears that we go ahead and allocate the right thing in both cases that I have access to (CF cards, CDROM, and external ata enclosures), so go ahead and ignore the failure to get the resource for the other rid. There's already another check to make sure that the actual allocation works correctly, and that should be sufficient to catch cases that don't work. Submitted by: wpaul and iedowse Revision Changes Path 1.15 +0 -4 src/sys/dev/ata/ata-card.c