From owner-freebsd-current@FreeBSD.ORG Mon Feb 9 03:34:28 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EC0A81065672; Mon, 9 Feb 2009 03:34:28 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.179]) by mx1.freebsd.org (Postfix) with ESMTP id B93E38FC08; Mon, 9 Feb 2009 03:34:28 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: by wa-out-1112.google.com with SMTP id k34so817659wah.27 for ; Sun, 08 Feb 2009 19:34:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=0jUqRwxWpVhs/mnfHHHYH9YBp/lqVbgKLV2pS8+Dzzg=; b=i5PFDPgh9CMdjNjaFHHmKBCoi58SQbtOM4zzgu/p99AY9JI9j38NAd3ESM+la0NYXZ m/xylLAhVo1gGOcV2Z80jJjcI75IaLZU3wqqfv017TlDe+h9uglDGlvT3z6zWlDw/sh8 WtdlBRtxYwpBQX26aRouH8mmIWForJsxxI0HA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=G21+WeUxvRCHqq1IYnv09GAzGd889U/V9/yPNEpmqF5eKKmyMXyE9nxYkHVHL+aCA7 +tKARFKrF3R69DAcqcz39do/3ZFvcAyF4AYOhDdpzmjyg2LMk34xGPaX4IimUafcOeVm JAwfN6gOm7/ohp3XkjgANV2mIFWaYeK9cdDxA= MIME-Version: 1.0 Received: by 10.114.89.1 with SMTP id m1mr3255725wab.35.1234150468393; Sun, 08 Feb 2009 19:34:28 -0800 (PST) In-Reply-To: <1de79840902081724k243fc300n97dd4f430e0c6cde@mail.gmail.com> References: <7d6fde3d0902081659i7cb86al921ea109d17e1a3c@mail.gmail.com> <1de79840902081724k243fc300n97dd4f430e0c6cde@mail.gmail.com> Date: Sun, 8 Feb 2009 19:34:28 -0800 Message-ID: <7d6fde3d0902081934w18ea7a0fgdd0d603ea822f660@mail.gmail.com> From: Garrett Cooper To: Michael Proto Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: rrs@freebsd.org, FreeBSD Current Subject: Re: WITHOUT_INET6 broken on CURRENT X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Feb 2009 03:34:29 -0000 On Sun, Feb 8, 2009 at 5:24 PM, Michael Proto wrote: > On Sun, Feb 8, 2009 at 7:59 PM, Garrett Cooper wrote: >> Hi Randall, >> I recently rebuilt my sources today and I noticed that it's now >> breaking on a valid warning with sctp: >> >> cc -c -O2 -frename-registers -pipe -fno-strict-aliasing -march=nocona >> -std=c99 -g -Wall -Wredundant-decls -Wnested-externs >> -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline >> -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc >> -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL >> -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common >> -finline-limit=8000 --param inline-unit-growth=100 --param >> large-function-growth=1000 -fno-omit-frame-pointer -mcmodel=kernel >> -mno-red-zone -mfpmath=387 -mno-sse -mno-sse2 -mno-sse3 -mno-mmx >> -mno-3dnow -msoft-float -fno-asynchronous-unwind-tables >> -ffreestanding -fstack-protector -Werror >> /usr/src/sys/netinet/sctputil.c >> cc1: warnings being treated as errors >> In file included from /usr/src/sys/netinet/sctputil.c:6553: >> /usr/src/sys/netinet6/sctp6_var.h:57: warning: 'struct icmp6_hdr' >> declared inside parameter list >> /usr/src/sys/netinet6/sctp6_var.h:57: warning: its scope is only this >> definition or declaration, which is probably not what you want >> *** Error code 1 >> >> Stop in /usr/obj/usr/src/sys/OPTIMUS. >> *** Error code 1 >> >> Stop in /usr/src. >> *** Error code 1 >> >> Stop in /usr/src. >> >> I'm going to rebuild setting WITHOUT_SCTP for now, but this needs >> to be fixed. >> Thanks, >> -Garrett > > > IIRC SCTP has always required INET6 to compile since it was first > introduced. I thought it was a prerequisite. > > -Proto In that file there's a #ifdef INET6 -- maybe that should be #if INET6? Also, it's a preprocessor define that doesn't disable any features as well. Also, about INET6 support -- this blurb from the manpage for sctp makes me believe that IPV6 isn't required (pardon the formatting -- a direct paste really screwed up the spacing): SCTP_I_WANT_MAPPED_V4_ADDR SCTP supports both IPV4 and IPV6. An associ- ation may span both IPV4 and IPV6 addresses since SCTP is multi-homed. By default, when opening an IPV6 socket, when data arrives on the socket from a peer's V4 address the V4 address will be presented with an address family of AF_INET. If this is undesireable, then this option can be enabled which will then convert all V4 addresses into mapped V6 representations. Thanks, -Garrett