From owner-cvs-all  Sat May 26 22:24:40 2001
Delivered-To: cvs-all@freebsd.org
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by hub.freebsd.org (Postfix) with ESMTP
	id E090037B424; Sat, 26 May 2001 22:24:35 -0700 (PDT)
	(envelope-from imp@harmony.village.org)
Received: from harmony.village.org (localhost.village.org [127.0.0.1])
	by harmony.village.org (8.11.3/8.11.1) with ESMTP id f4R5ONE52094;
	Sat, 26 May 2001 23:24:33 -0600 (MDT)
	(envelope-from imp@harmony.village.org)
Message-Id: <200105270524.f4R5ONE52094@harmony.village.org>
To: Dima Dorfman <dima@unixfreak.org>
Subject: Re: cvs commit: src/usr.sbin/kbdcontrol kbdcontrol.c 
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
In-reply-to: Your message of "Sat, 26 May 2001 21:50:57 PDT."
		<20010527045057.A800E3E30@bazooka.unixfreak.org> 
References: <20010527045057.A800E3E30@bazooka.unixfreak.org>  
Date: Sat, 26 May 2001 23:24:23 -0600
From: Warner Losh <imp@harmony.village.org>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

In message <20010527045057.A800E3E30@bazooka.unixfreak.org> Dima Dorfman writes:
: I agree that this is a better solution than what I committed, but I
: still think `kbdcontrol -L` should be factored out into another
: program.  It seems silly that kbdcontrol can't rely on up-to-date
: headers like most other programs in the system.

I think that's likely an excellent idea.  However, there are some
issues with this.  Some large number of items are defined in
sys/kbdio.h, which makes it hard to disentangle.  A kludge version can
be found at http://people.freebsd.org/~imp/kbddump.c.  It would be
better to make this something that could be built into kbdcontrol, or
built stand alone on a host to generate the keyboard .h files.

: > Consider the following untested patch:
: 
: If we can't/won't factor out `kbdcontrol -L`, I'll commit this.
: Thanks!  I knew there had to be a better way than defining an ioctl in
: the userland :-).

I'd commit this right away while people bikeshed the kbdcontrol :-)

Warner

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message