From owner-freebsd-rc@FreeBSD.ORG  Wed Apr  6 04:41:22 2011
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
Delivered-To: freebsd-rc@freebsd.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id DFA6A106564A;
	Wed,  6 Apr 2011 04:41:22 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from 65-241-43-5.globalsuite.net (hub.freebsd.org
	[IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id A20EB1A6E4C;
	Wed,  6 Apr 2011 04:41:17 +0000 (UTC)
Message-ID: <4D9BEEEC.4050109@FreeBSD.org>
Date: Tue, 05 Apr 2011 21:41:16 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.15) Gecko/20110319 Thunderbird/3.1.9
MIME-Version: 1.0
To: Attilio Rao <attilio@freebsd.org>
References: <BANLkTimmFfYPLpSVM7WHyH=VtjPp=uMJwA@mail.gmail.com>
In-Reply-To: <BANLkTimmFfYPLpSVM7WHyH=VtjPp=uMJwA@mail.gmail.com>
X-Enigmail-Version: 1.1.2
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-rc@freebsd.org, Ed Maste <emaste@sandvine.com>
Subject: Re: [PATCH] Adding netdumpsrv rc.d script
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
	<freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Apr 2011 04:41:23 -0000

The rc.d script and related look fine. The only thing I'd change is a 
blank line before run_rc_command (a stylistic convention). Don't forget 
the update to rc.conf.5 as well.

hope this helps,

Doug


On 04/05/2011 13:52, Attilio Rao wrote:
> Hello,
> I wanted to know if anyone here could review the netdumpsrv script I'm
> adding for netdumpsrv.
>
> netdumpsrv is a daemon that I'm developing on the following project branch:
> http://svn.freebsd.org/base/projects/sv/
>
> and that I hope to merge to HEAD asap.
>
> You can have an overview of the man page, for the daemon, here:
> http://svn.freebsd.org/base/projects/sv/usr.sbin/netdumpsrv/netdumpsrv.8
>
> And this is the rc.d script fixup I want to add:
> http://www.freebsd.org/~attilio/Sandvine/STABLE_8/netdump/netdumpsrvrcd.diff
>
> Any advice would be appreciated.
>
> Thanks,
> Attilio
>
>



-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/