From owner-dev-commits-src-all@freebsd.org  Thu Jan 21 15:21:11 2021
Return-Path: <owner-dev-commits-src-all@freebsd.org>
Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id C77774F7392;
 Thu, 21 Jan 2021 15:21:11 +0000 (UTC)
 (envelope-from carpeddiem@gmail.com)
Received: from mail-io1-f50.google.com (mail-io1-f50.google.com
 [209.85.166.50])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4DM5h75Cnrz4WZj;
 Thu, 21 Jan 2021 15:21:11 +0000 (UTC)
 (envelope-from carpeddiem@gmail.com)
Received: by mail-io1-f50.google.com with SMTP id d13so4672689ioy.4;
 Thu, 21 Jan 2021 07:21:11 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=/1S0OXeVx2PFBkqRKXAzLkAs09EOdJEEz7kc0sjc0cQ=;
 b=sUAaVtDWojS+zCDqe44W+Ur9zjWmAO/kEH5D0Gf3HsFd2zbaLoVVHqCVTs2lcE33PP
 eWiZWGEuPDfaX2zeuspIdK+6TKsQEv0t80bC9BPfLcsrTr9iamf15NuH5PFx1hbD9MJ1
 631+Soff95nn1m5u1nU/cbQki82xW8W5x9SGj4rRz6Vv6QRFrUDVnk4yJ0uuNiS2M9pU
 O3NboJ5LRyTbBu+PTSoX6YPGmDi1snvBNJAppC4ok5rtn6OAE9WZXf48XnfjtoJ83GHQ
 7eT9p6JmecEoYaVUTPmpqRTxuEEc/gOuqoygHlQMwIavH1SlsljM5drGm8416i48zsIN
 k4kg==
X-Gm-Message-State: AOAM532AzYp102dEY4mupCbS7Ggk1Qnxqec//n9scFaARl6MoiEIDamz
 xd+hY3xCFBYQnTzKzewE1Akq1Xb01nhi7ExTnARwGTp41vU=
X-Google-Smtp-Source: ABdhPJxEurQORPIFzFTk6qKAC+axHqfcygDwDX3t73q6j+/xfCWkDLNPcMg2OpXEIlnpeCFV+Ob04uCAQbTVdT2fV/0=
X-Received: by 2002:a92:ce41:: with SMTP id a1mr217530ilr.182.1611242469834;
 Thu, 21 Jan 2021 07:21:09 -0800 (PST)
MIME-Version: 1.0
References: <202101200949.10K9nmkZ029085@gitrepo.freebsd.org>
 <CAGudoHG9KGDH0d23d6F1pCmfApYGFc37ZYmK-gxqgY3Ua_80CA@mail.gmail.com>
 <CAPyFy2C7jFAP27OW2zHAwoWHpnWpEQTU7tkVpJcMWgTfTGQPHQ@mail.gmail.com>
 <CAGudoHF8=G1u7n4iQg-DLGGZ7i4Y-5rzgSTHxKs6mS_r2AXD4A@mail.gmail.com>
 <49353415-D1B2-43D5-AC39-EF64F03EE512@freebsd.org>
In-Reply-To: <49353415-D1B2-43D5-AC39-EF64F03EE512@freebsd.org>
From: Ed Maste <emaste@freebsd.org>
Date: Thu, 21 Jan 2021 10:20:45 -0500
Message-ID: <CAPyFy2DTv_5NdqLJ6YysC=hoy-NzKRpAvsHbbKg8SRRxsJ=rAw@mail.gmail.com>
Subject: Re: git: a9fc14fbf445 - main - newvers.sh: add support for gitup(1)
To: Jessica Clarke <jrtc27@freebsd.org>
Cc: Mateusz Guzik <mjguzik@gmail.com>,
 =?UTF-8?Q?Ulrich_Sp=C3=B6rlein?= <uqs@freebsd.org>, 
 src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, 
 dev-commits-src-main@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-Rspamd-Queue-Id: 4DM5h75Cnrz4WZj
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-BeenThere: dev-commits-src-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the src repository
 <dev-commits-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-all/>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Help: <mailto:dev-commits-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Jan 2021 15:21:11 -0000

> > This fixes the problem at hand,

Thanks for confirming, I've fixed that part now.

> > but a new regression is shown:
> >
> > $ strings kernel | grep 'FreeBSD 13.0-ALPHA1'
> > FreeBSD 13.0-ALPHA1 #47 c256181-gb06e91d1b700: Thu Jan 21 14:31:35 UTC 2021
> >
> > branch name is no longer present.
>
> See the commit message, though I'd argue it's not redundant in a lot of
> local development cases (i.e. anything other than main, stable/*, etc),
> and is actually rather useful.

I agree, and my suggestion is that we restore it unconditionally. I
think it's more confusing without a consistent format / set of
components.