From owner-cvs-all  Wed Sep 18  6:12: 2 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3093E37B401; Wed, 18 Sep 2002 06:12:01 -0700 (PDT)
Received: from bast.unixathome.org (bast.unixathome.org [216.187.105.150])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9DCE943E4A; Wed, 18 Sep 2002 06:12:00 -0700 (PDT)
	(envelope-from dan@langille.org)
Received: from wocker (wocker.unixathome.org [192.168.0.99])
	by bast.unixathome.org (Postfix) with ESMTP
	id 50BE13F4B; Wed, 18 Sep 2002 09:11:59 -0400 (EDT)
From: "Dan Langille" <dan@langille.org>
To: Peter Pentchev <roam@FreeBSD.org>
Date: Wed, 18 Sep 2002 09:12:44 -0400
MIME-Version: 1.0
Subject: Re: cvs commit: ports/devel/gindent Makefile pkg-plist ports/devel/gindent/files patch-doc:Makefile.in
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Message-ID: <3D88438C.16000.41888E90@localhost>
In-reply-to: <200209181232.g8ICWbq4059604@freefall.freebsd.org>
X-mailer: Pegasus Mail for Windows (v4.02)
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7BIT
Content-description: Mail message body
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On 18 Sep 2002 at 5:32, Peter Pentchev wrote:

> roam        2002/09/18 05:32:37 PDT
> 
>   Modified files:
>     devel/gindent        Makefile pkg-plist 
>     devel/gindent/files  patch-doc:Makefile.in 
>   Log:
>   Support CFLAGS/CXXFLAGS properly.
>   Honor NOPORTDOCS.

Waking up this morning, FreshPorts tells me[1] there is a problem 
with this port:

[dan@undef:~/ports/devel/gindent] $ make -V PORTVERSION
"/usr/home/dan/ports/devel/gindent/Makefile", line 36: Malformed 
conditional (!defiend(NOPORTDOCS))
"/usr/home/dan/ports/devel/gindent/Makefile", line 40: if-less endif
"/usr/home/dan/ports/devel/gindent/Makefile", line 40: Need an 
operator
make: fatal errors encountered -- cannot continue
[dan@undef:~/ports/devel/gindent] $

Here's the patch:

-.if !defiend(NOPORTDOCS)
+.if !defined(NOPORTDOCS)

[1] - FreshPorts would have told roam if he was opt'd in at 
FreshPorts.  FreshPorts runs a sanity test on every port commit.  If 
a commiter opts in, any errors found in their commits are reported 
directly to them instead of me being the go between.  I urge every 
port committer to opt in.  It saves me the bother of reporting your 
errors to you and the world.  It also means the problem is fixed much 
sooner.  At present, we have 15 opt'd in committers, where are the 
rest of you?

-- 
Dan Langille
I'm looking for a computer job:
http://www.freebsddiary.org/dan_langille.php


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message