From owner-svn-src-head@FreeBSD.ORG  Tue Dec 25 07:40:12 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 31094EA8;
 Tue, 25 Dec 2012 07:40:12 +0000 (UTC)
 (envelope-from luigi@onelab2.iet.unipi.it)
Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238])
 by mx1.freebsd.org (Postfix) with ESMTP id DAD258FC14;
 Tue, 25 Dec 2012 07:40:10 +0000 (UTC)
Received: by onelab2.iet.unipi.it (Postfix, from userid 275)
 id 91D1D7300A; Tue, 25 Dec 2012 08:38:54 +0100 (CET)
Date: Tue, 25 Dec 2012 08:38:54 +0100
From: Luigi Rizzo <rizzo@iet.unipi.it>
To: Gleb Smirnoff <glebius@FreeBSD.org>
Subject: Re: svn commit: r244665 - head/sys/netinet
Message-ID: <20121225073854.GA16201@onelab2.iet.unipi.it>
References: <201212242135.qBOLZnF8085020@svn.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201212242135.qBOLZnF8085020@svn.freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Dec 2012 07:40:12 -0000

On Mon, Dec 24, 2012 at 09:35:49PM +0000, Gleb Smirnoff wrote:
> Author: glebius
> Date: Mon Dec 24 21:35:48 2012
> New Revision: 244665
> URL: http://svnweb.freebsd.org/changeset/base/244665
> 
> Log:
>   Minor style(9) changes:
>   - Remove declaration in initializer.

i am really curious, what is the point of removing one
initialization out of three ?
(and if anything, the 'register' should have gone...)

cheers
luigi

>   - Add empty line between logical blocks.
> 
> Modified:
>   head/sys/netinet/in.c
> 
> Modified: head/sys/netinet/in.c
> ==============================================================================
> --- head/sys/netinet/in.c	Mon Dec 24 20:33:37 2012	(r244664)
> +++ head/sys/netinet/in.c	Mon Dec 24 21:35:48 2012	(r244665)
> @@ -799,7 +799,7 @@ in_ifinit(struct ifnet *ifp, struct in_i
>      int masksupplied, int vhid)
>  {
>  	register u_long i = ntohl(sin->sin_addr.s_addr);
> -	int flags = RTF_UP, error = 0;
> +	int flags, error = 0;
>  
>  	IN_IFADDR_WLOCK();
>  	if (ia->ia_addr.sin_family == AF_INET)
> @@ -843,9 +843,11 @@ in_ifinit(struct ifnet *ifp, struct in_i
>  	}
>  	ia->ia_subnet = i & ia->ia_subnetmask;
>  	in_socktrim(&ia->ia_sockmask);
> +
>  	/*
>  	 * Add route for the network.
>  	 */
> +	flags = RTF_UP;
>  	ia->ia_ifa.ifa_metric = ifp->if_metric;
>  	if (ifp->if_flags & IFF_BROADCAST) {
>  		if (ia->ia_subnetmask == IN_RFC3021_MASK)