Date: Thu, 24 Jan 2002 19:58:41 +0100 From: Guido van Rooij <guido@gvr.org> To: Josef Karthauser <joe@tao.org.uk> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb umass.c Message-ID: <20020124185841.GA63552@gvr.gvr.org> In-Reply-To: <20020124161913.A26357@genius.tao.org.uk> References: <200201241510.g0OFAsL61861@freefall.freebsd.org> <20020124161913.A26357@genius.tao.org.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 24, 2002 at 04:19:13PM +0000, Josef Karthauser wrote: > > Modified files: > > sys/dev/usb umass.c > > Log: > > 1) Fix a debug statement by filling in its data before the printf in > > stead of after > > 2) Honour NO_TEST_UNIT_READY quirk for atapi devices as well > > 3) Actually support FujiFilm FinePix 6800 camera's. Will very likely also > > work for other FinePix models. > > > > Based on a debug session about half a year ago with Nik Hibma. > > MFC after: 2 weeks > > Hi Guido, > > This is a big change. I'd appreciate it if in future an USB patches > were run by me first. I've been working hard to sychronise the USB > stack with the NetBSD code. You don't mention here whether this code > came from NetBSD or was developed in house. If the latter then we > need to get these patches back to NetBSD, if the former it's good idea > to mention the revision numbers in the commit. Sorry, you are right here. It is just that it was developped in a session with Nik when he was still `in charge'. It just never was commited. And since I had to change the code a bit because of the restructuring in the am error processing, I was thinking: let's have it comitted asap. It was developped in-house, and, as you can see, it is a real quirk: apparently, these devices do not clear the Unit Attention state on a request_sense command. -Guido To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020124185841.GA63552>