From owner-freebsd-net@FreeBSD.ORG  Tue Oct  8 18:46:12 2013
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 286DD853
 for <freebsd-net@freebsd.org>; Tue,  8 Oct 2013 18:46:12 +0000 (UTC)
 (envelope-from luigi@onelab2.iet.unipi.it)
Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238])
 by mx1.freebsd.org (Postfix) with ESMTP id DF81F27BF
 for <freebsd-net@freebsd.org>; Tue,  8 Oct 2013 18:46:11 +0000 (UTC)
Received: by onelab2.iet.unipi.it (Postfix, from userid 275)
 id 705A57300A; Tue,  8 Oct 2013 20:47:52 +0200 (CEST)
Date: Tue, 8 Oct 2013 20:47:52 +0200
From: Luigi Rizzo <rizzo@iet.unipi.it>
To: Eric van Gyzen <eric_van_gyzen@dell.com>
Subject: Re: sys/net/radix.h: #define Free(p) for user-land
Message-ID: <20131008184752.GA97567@onelab2.iet.unipi.it>
References: <5252D7F7.3030709@dell.com> <20131008141504.GA22563@FreeBSD.org>
 <52541ABF.70101@dell.com> <5254495E.3050206@dell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5254495E.3050206@dell.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: freebsd-net@freebsd.org, Eric van Gyzen <eric@vangyzen.net>
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Oct 2013 18:46:12 -0000

On Tue, Oct 08, 2013 at 01:05:18PM -0500, Eric van Gyzen wrote:
> On 10/08/2013 09:46, Eric van Gyzen wrote:
> > On 10/08/2013 09:15, Gleb Smirnoff wrote:
> >> On Mon, Oct 07, 2013 at 10:49:11AM -0500, Eric van Gyzen wrote:
...
> >> The easiest way to find consumers would be to build test the trivial patch :)
> > Gleb,
> >
> > So true.  :)  Before I bothered, I just wanted to ask if a change was
> > impractical due to API commitments with several known out-of-tree
> > consumers.  Hearing no such replies, I'll test a patch.
> 
> I simply renamed Free to R_Free, and buildworld succeeded.  I built head
> r256133 on amd64 with no make.conf or src.conf.
> 
> So, there are [probably] no in-tree consumers.  The question then
> becomes, do we need these user-land definitions at all?

I am pretty sure there are no in-tree consumers,
but for the time being please do keep the userland definitions
since they are already there.

In general it is useful to be able to compile kernel code in
userland for functional and performance testing.
One could argue that the wrappers could be implemented in a
more generic way, but it will probably take a while (or forever)
before we get there...

cheers
luigi