From owner-cvs-all Fri Feb 1 11:25:44 2002 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 68EC237B400; Fri, 1 Feb 2002 11:25:36 -0800 (PST) Received: (from alfred@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g11JPat66504; Fri, 1 Feb 2002 11:25:36 -0800 (PST) (envelope-from alfred) Message-Id: <200202011925.g11JPat66504@freefall.freebsd.org> From: Alfred Perlstein Date: Fri, 1 Feb 2002 11:25:36 -0800 (PST) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern kern_descrip.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG alfred 2002/02/01 11:25:36 PST Modified files: sys/kern kern_descrip.c Log: Remove bogus assertion in dup2 that can lead to panics when kernel threads race for a file slot. dup2(2) incorrectly assumes that if it needs to grow the ofiles array that it will get what it wants. This assertion was valid before we allowed shared filedescriptor tables but is now incorrect. The assertion can trigger superfolous panics if the thread doing a dup2 looses a race with another thread while possibly blocked in the MALLOC call in fdalloc. Another thread may grab the slot we are requesting which makes fdalloc return something other than what we asked for, this will triggering the bogus assertion. MFC after: 2 weeks Reviewed by: phk Revision Changes Path 1.124 +0 -2 src/sys/kern/kern_descrip.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message