From owner-svn-ports-all@freebsd.org Thu Aug 4 05:51:18 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1C03FBAE439; Thu, 4 Aug 2016 05:51:18 +0000 (UTC) (envelope-from marino@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C16B613BC; Thu, 4 Aug 2016 05:51:17 +0000 (UTC) (envelope-from marino@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u745pGHx069777; Thu, 4 Aug 2016 05:51:16 GMT (envelope-from marino@FreeBSD.org) Received: (from marino@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u745pG5j069776; Thu, 4 Aug 2016 05:51:16 GMT (envelope-from marino@FreeBSD.org) Message-Id: <201608040551.u745pG5j069776@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: marino set sender to marino@FreeBSD.org using -f From: John Marino Date: Thu, 4 Aug 2016 05:51:16 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r419596 - head/japanese/libtomoe-gtk X-SVN-Group: ports-head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Aug 2016 05:51:18 -0000 Author: marino Date: Thu Aug 4 05:51:16 2016 New Revision: 419596 URL: https://svnweb.freebsd.org/changeset/ports/419596 Log: japanese/libtomoe-gtk: fix illegal placement of USES USES must be defined before any inclusions like or
,
  otherwise they can't get registered as run dependencies.  The presence
  of USES=python after 
 was trying to build+run dependency on
  python conditionally based on the presence of an installed file.
  
  Since the condition can't be moved up due to the LOCALBASE variable,
  I've moved python up but changed it to USES+=python:build so that
  python will never be registered as a run dependency, but it will be
  available if required for building.  The alternative is register
  python as a run dependency in every case because the port can't stay
  how it is.  I picked the more conservative option I think.
  
  Approved by:	just-fix-it

Modified:
  head/japanese/libtomoe-gtk/Makefile

Modified: head/japanese/libtomoe-gtk/Makefile
==============================================================================
--- head/japanese/libtomoe-gtk/Makefile	Thu Aug  4 05:12:10 2016	(r419595)
+++ head/japanese/libtomoe-gtk/Makefile	Thu Aug  4 05:51:16 2016	(r419596)
@@ -3,7 +3,7 @@
 
 PORTNAME=	libtomoe-gtk
 PORTVERSION=	0.6.0
-PORTREVISION=	9
+PORTREVISION=	10
 CATEGORIES=	japanese
 MASTER_SITES=	SF/tomoe/tomoe-gtk/tomoe-gtk-${PORTVERSION}
 DISTNAME=	tomoe-gtk-${DISTVERSIONPREFIX}${DISTVERSION}${DISTVERSIONSUFFIX}
@@ -14,7 +14,7 @@ COMMENT=	TOMOE GTK+ library
 LIB_DEPENDS=	libtomoe.so:japanese/tomoe
 
 GNU_CONFIGURE=	yes
-USES=		gmake libtool pathfix pkgconfig
+USES=		gmake libtool pathfix pkgconfig python:build
 USE_GNOME=	gtk20
 USE_LDCONFIG=	yes
 
@@ -31,7 +31,6 @@ PLIST_SUB+=	GUCHARMAP="@comment "
 #.endif
 
 .if exists(${LOCALBASE}/libdata/pkgconfig/pytomoe.pc)
-USES+=		python
 CONFIGURE_ENV+=	PYTHON_VERSION=${PYTHON_VERSION:S;python;;} \
 		pyexecdir=${PYTHON_SITELIBDIR}
 PLIST_SUB+=	PYTHON=""