From nobody Fri May 17 06:00:05 2024 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VgbsN5wP4z5KVtx for ; Fri, 17 May 2024 06:00:08 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4VgbsN04bdz4h60; Fri, 17 May 2024 06:00:07 +0000 (UTC) (envelope-from manu@bidouilliste.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1715925605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+N3Ks7O38dijY2fCKS9ioH0SVMKJ3QvzCeGX3M5barE=; b=WXdfV7B7Di3zWRepxqoXjD6b2aR57+GD6aZrZWzEU0ZuIesUxVeXiPu1v/K4Ras38Zo9Ag oOTfPENjBy6jgf6oKJjQvNR8xv3qHnehwgUr2WvP6C7snuQrsEBZShn9W1/0AXU8KD+t1V IfRvsLouIheb8cBmjmxOd8h87aw43hk= Received: from skull.home.blih.net (lfbn-lyo-1-2174-135.w90-66.abo.wanadoo.fr [90.66.97.135]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 9007815c (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 17 May 2024 06:00:05 +0000 (UTC) Date: Fri, 17 May 2024 08:00:05 +0200 From: Emmanuel Vadot To: Ryan Libby Cc: current@freebsd.org, manu@freebsd.org Subject: Re: Panic: lock "lnxspin" 0xfffff800176c0730 already initialized Message-Id: <20240517080005.b35f98bffac25bb6b5a7a119@bidouilliste.com> In-Reply-To: References: <20240517065557.1c184ec92447e074783a6a1c@bidouilliste.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd15.0) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR] X-Rspamd-Queue-Id: 4VgbsN04bdz4h60 On Thu, 16 May 2024 22:10:16 -0700 Ryan Libby wrote: > On Thu, May 16, 2024 at 9:56?PM Emmanuel Vadot wr= ote: > > > > On Thu, 16 May 2024 10:27:40 -0700 > > Ryan Libby wrote: > > > > > On Thu, May 16, 2024 at 6:00?AM David Wolfskill wrote: > > > > > > > > This is running main-n270174-abb1a1340e3f (built in-place from > > > > main-n270163-154ad8e0f88f), with ports at main-n663685-3f732745ab06; > > > > the ports-resident kernel modules were rebuilt with the kernel, > > > > courtesy (e.g.): > > > > > > > > g1-70(14.1-S)[4] grep '^PORT' /etc/src.conf > > > > PORTS_MODULES+=3Dgraphics/drm-61-kmod > > > > > > > > And since I dislike "sample sizes of one," I have this result on > > > > two different laptops, each of which has both Nvidia & Intel graphi= cs > > > > (but for the older one (M4800), I stopped using (& building) the > > > > Nvidia driver, since enabling it appears to disable GLX). > > > > > > > > Anyway: photos of the backtraces are at > > > > https://www.catwhisker.org/~david/FreeBSD/head/n270174/ > > > > as are copies of the build typescripts. > > > > > > > > Unfortunately, the panic message itself had (just) scrolled off the > > > > top at the time I took the photos, but I hand-typed it (from the > > > > M4800) in the Subject. > > > > > > > > Peace, > > > > david > > > > -- > > > > David H. Wolfskill david@catwhisker.org > > > > Please do not mistake "authoritarian" for "conservative" -- or vice= versa. > > > > > > > > See https://www.catwhisker.org/~david/publickey.gpg for my public k= ey. > > > > > > Maybe regression from ae38a1a1bfdf320089c254e4dbffdf4769d89110 by man= u. > > > > > > It looks like spin_lock_init was changed to no longer zero out the > > > mutex before calling mtx_init, but the MTX_NEW flag was not added. > > > > > > Ryan > > > > > > > Could be, I cannot reproduce this here (either with i915kms or amdgpu) > > but I guess that depending on the hardware version or number of screens > > etc ... code path is different and might trigger this. > > David can you test with > > https://people.freebsd.org/~manu/0001-linuxkpi-Fix-spin_lock_init.patch > > just to be sure that it fixes this issue ? > > > > Cheers, > > > > -- > > Emmanuel Vadot >=20 > It may depend on getting lucky with the uninitialized junk too, and you w= ould > need a kernel with KASSERTs enabled. >=20 > manu, I think the rwlock patch 5c0a1923486e65cd47398e52c03cb289d6120a78 > may need the same treatment with RW_NEW. >=20 > Ryan >=20 Indeed, even if I know that I tested with GENERIC and amdgpu I think that I've only tested GENERIC-NODEBUG with i915kms. Anyway, I've pushed both patches now. Sorry for the breakage. Cheers, --=20 Emmanuel Vadot