From nobody Fri Jul 25 19:09:24 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bpcr34cXDz62Dc9 for ; Fri, 25 Jul 2025 19:09:39 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bpcr25v3dz3NFf for ; Fri, 25 Jul 2025 19:09:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-3122a63201bso1883788a91.0 for ; Fri, 25 Jul 2025 12:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1753470576; x=1754075376; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=K1kx+xDNUHDa/bMLIb0x+InBZR/b6t6JCWLkC5VhhOI=; b=ZUZoKtIAozjHGABl5yemXI0RiGr0r+lZeJqCnFEiA5GRlPWTkshHjw1Q3h2Z0PYwW0 tjf+FfrSMyS8YcsswZn/pTULbXz2WnVgkb2dEjEHgeV8mFRAw6KTP53ek93HuAuX2H75 uWI9z0Aj3c/DPb3Jj/WfPH6bfcrFneI/6I0zn4qxdH8d5l5+THrojamLccRPozHQcvKK U+02aWW8Oy3PZNnYuQbI7UUiLBtZSt0z4EqdrBtOpphS6Z6HFkrqmnWLC+cuOfGlZTcX AgiT9RTU5hLp9pwQcUrBAruP6aDV5fqZ0OBTsWpXQ0CpeDwaJCck9Uyd2fIMJLPlVZ54 6lDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753470576; x=1754075376; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K1kx+xDNUHDa/bMLIb0x+InBZR/b6t6JCWLkC5VhhOI=; b=BSR5Zs3kohLMtoxkt4plvjGKs7FJiOYDtE7dJhcBbdDF3eArzIngya8uwKZ+MUEJxO aWXQM4URheXdnAzC1ATeHVAEgOX0VZLXYUVORrx2jOa/PRij8vhJ3A8a9RvWZbEIZgeD Q+DYjlwAyZL66SGoupfZpP/sRK7Fs3yOY3Hw4PVUlXSgv5KIcmIqsdzhJ+X6gEFTkA3f Rl4f9fMx4o0L/bcRXrJnsVZFWWHeK6m7yPn7TMDqx5Wo3C5TGm6oLcX+8Wt3LDpb2/BS H3UZsCZeN5rFBC4AMGQe0DhphckcbZMTK73TtvuyYnpAG7WeiUrgFf8CTZzRp09r+2GE bbaw== X-Forwarded-Encrypted: i=1; AJvYcCUFanjNe3CooVDHdkOdMjA1xPDX6Iq9FvqRj1FvZC5c9mSVIyF6YVQP+1qrfWQx+WkJr50a+K+zZXjJthQaDzfhJJjdZg==@freebsd.org X-Gm-Message-State: AOJu0YwODkENV+CHQ6c091cDB0IioSF6w/Fv9Cfr8hLVVELbFrOb0xF6 n/qJrLtDuO8S+EJlogs+GylPmD8YDPYisE2KIC4Wue4jmx0pur2HFqOaNRip0OxNwSaIc3H3MvW W7DymSrZpN0+KieGayts0Xx8cPHQ4eSdlkXFBe+HMQg== X-Gm-Gg: ASbGnctzRHGCkoroW7xsq4eO4T0+94VKRBo1Eno9yt14XARzdTChVoY4R2shlNGG+q0 CC999xV6OiUeiEVe2WLlDEQhg0BZIMkPVJdBYnzI0x8tns+bnoC99wXiyHpFzMT0vwNZosF3RSN L2d1/XjDhnhKCSlfs5dbW2EUdDisp/dkmQPOPlNE+dQ/q1N55u97ibhEzDkoV/ku2M06yt2yp+B U3taFc= X-Google-Smtp-Source: AGHT+IEALg3uTOGlqujJPt8vj1b0+qLwqZPAYC28d662GIOXTyziARPBtE+fMuV5GxczDELMkcsfTcTPWuzUUwg3dBg= X-Received: by 2002:a17:90b:3c81:b0:312:e9d:4002 with SMTP id 98e67ed59e1d1-31e77a140c0mr4444426a91.28.1753470575831; Fri, 25 Jul 2025 12:09:35 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202507211410.56LEAD6J066633@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Fri, 25 Jul 2025 13:09:24 -0600 X-Gm-Features: Ac12FXzBVfv79BfMmrSNAoJI-E5VMII5YX98S2hrl6Q1BnnM0QJcImCtkcnZBRk Message-ID: Subject: Re: git: c7da9fb90b0b - main - KRB5: Enable MIT KRB5 by default To: Wolfram Schneider Cc: Cy Schubert , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4bpcr25v3dz3NFf X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] On Fri, Jul 25, 2025 at 7:30=E2=80=AFAM Wolfram Schneider wrote: > > On Mon, 21 Jul 2025 at 16:10, Cy Schubert wrote: > > > > The branch main has been updated by cy: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3Dc7da9fb90b0b6385e99bb774= 7476359b712993fa > > > > commit c7da9fb90b0b6385e99bb7747476359b712993fa > > Author: Cy Schubert > > AuthorDate: 2025-07-19 14:11:18 +0000 > > Commit: Cy Schubert > > CommitDate: 2025-07-21 14:07:22 +0000 > > > > KRB5: Enable MIT KRB5 by default > > > > Set WITH_MITKRB5=3Dyes as the default. > > > > Rebuild all USES=3Dgssapi ports is recommended. > > > > A clean buildworld is required. > > > > Relnotes: yes > > IMHO this commit breaks cross compiling of FreeBSD on macOS due a > missing include file 'endian.h' > > make buildworld > [...] > clang -O2 -pipe -fno-common -Wno-deprecated-non-prototype > -Wno-macro-redefined -Wno-unused-parameter > -I/Users/wosch/projects/wosch-src/crypto/krb5/src/util/support > -I/Users/wosch/projects/wosch-src/crypto/krb5/src/include > -I/Users/wosch/projects/wosch-src/krb5/include > -I/var/folders/mw/16w0zx815gdb3xg581_8m2dh0000gn/T//freebsd-obj/Users/wos= ch/projects/wosch-src/arm64.aarch64/tmp/obj-tools/krb5/util/support > -Wno-deprecated-non-prototype -Wno-macro-redefined > -Wno-unused-parameter -MD -MF.depend.base64.o -MTbase64.o -std=3Dgnu17 > -Wno-format-zero-length -Wsystem-headers -Wno-pointer-sign -Wdate-time > -Wno-system-headers -Wno-empty-body -Wno-string-plus-int > -Wno-unused-const-variable -Wno-error=3Dunused-but-set-parameter > -Wno-error=3Dcast-function-type-mismatch -Wno-tautological-compare > -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function > -Wno-enum-conversion -Wno-unused-local-typedef > -Wno-address-of-packed-member -Wno-switch -Wno-switch-enum > -Wno-knr-promoted-parameter -Wno-parentheses -Wno-typedef-redefinition > -Werror=3Dincompatible-pointer-types-discards-qualifiers > -Qunused-arguments > -I/var/folders/mw/16w0zx815gdb3xg581_8m2dh0000gn/T//freebsd-obj/Users/wos= ch/projects/wosch-src/arm64.aarch64/tmp/legacy/usr/include > -Werror=3Dimplicit-function-declaration -Werror=3Dimplicit-int > -Werror=3Dreturn-type -Wundef -DHAVE_NBTOOL_CONFIG_H=3D1 > -D_DARWIN_C_SOURCE=3D1 > -I/Users/wosch/projects/wosch-src/tools/build/cross-build/include/mac > -idirafter /Users/wosch/projects/wosch-src/contrib/libarchive/libarchive > -I/Users/wosch/projects/wosch-src/tools/build/cross-build/include/common > -c /Users/wosch/projects/wosch-src/crypto/krb5/src/util/support/base64.c > -o base64.o > In file included from > /Users/wosch/projects/wosch-src/crypto/krb5/src/util/support/base64.c:36: > /Users/wosch/projects/wosch-src/crypto/krb5/src/include/k5-platform.h:439= :11: > fatal error: 'endian.h' file not found > 439 | # include > | ^~~~~~~~~~ > 1 error generated. > *** [base64.o] Error code 1 > bmake[3]: stopped making "all" in > /Users/wosch/projects/wosch-src/krb5/util/support > > As a workaround, you can set the makefile variable WITHOUT_MITKRB5=3D1 > and buildworld will work again on macOS. Adding a macos compat endian.h shim may be as simple as a one-liner "#include " depending on what kerberos uses from there. tools/build/cross-build/include/macos/endian.h would be where it goes. I'm about to depart on vacation, or I'd take a stab at this. Warner