From owner-svn-src-head@freebsd.org Sat Apr 22 20:59:32 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A5107D4B097; Sat, 22 Apr 2017 20:59:32 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6ED048FF; Sat, 22 Apr 2017 20:59:32 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-io0-x244.google.com with SMTP id k87so38461730ioi.0; Sat, 22 Apr 2017 13:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=lmao55jtrqoXc8UH4D+QZaWGXEwSz4cW2128BYAisjk=; b=G0BqOF9tzsj//cbwpo/S9LZasAlxusjKyeD9bY+dlHqgaI4X5/gYk0KCVxhR2YK8e1 GOF7ruGTIfkHJmgwYWcAPghL6geAG7n0phcPohLqZYu+UDW4TPKCiGmjWVlWxpHUctBv HhJrKA2+yxy3KbB6ifWEmW5M2SQ7IZBfb9YK883fOYw3kbkZ/kl8xtuL4ePzOE6q9NWk 7eEZMq8TCKuyRZg4VZbQ5wNkniK/Ikv+Thq4KWBPB8xjLcRj99Mk4Wby+T8U46Uo1gLj MvArFAMCeCZ0mXPCFhwTMn1xwIhEPny1Aye/nRcEhbPjXr9RPm4+IKN8qgvh3AcKZ2Lh htzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=lmao55jtrqoXc8UH4D+QZaWGXEwSz4cW2128BYAisjk=; b=iEElcI1SH3JrVy08WEzPKa84AzNk3gilqN3gY1SvPf6DSHlteJx3zssIHheGmdRl97 BkwbUfZj5EfNNfEZwnlsslRKYVXuNg9aZ9wacY+wF7Gc0DISMJcNCPh6l+jqiOs941zc QVkzYMxYfLXRR/n9CtkA7mWSKN9rKgPCijXTexpJTgpyJK7+rFyB3b575FlCNl2/LUtb f1CB/4jz6LDlbPor42cK6weOo9anpAj3rB6urpCuNU4t9D9nV9B9VF/8ApE73G4iCdQf AwwB1mnySrdDzK0VmikjnQeon2PEzYos7qsaOc/DtSQbrprNFJKV9GXkbMRRAg833X2W nZqA== X-Gm-Message-State: AN3rC/5TTOkfFS9HjphbaaZSAJtWv3ivUe1Js472k9fhlH8AGoJMXy3Y LpEMV4JdhjAUu9KlPlM= X-Received: by 10.98.100.75 with SMTP id y72mr17970903pfb.44.1492894771589; Sat, 22 Apr 2017 13:59:31 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id p2sm22907022pfj.93.2017.04.22.13.59.30 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 22 Apr 2017 13:59:30 -0700 (PDT) Subject: Re: svn commit: r317290 - head/tools/regression/geom_gpt Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_FE4CD735-896B-4905-8281-979374D404D9"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <201704222006.v3MK6fYX047692@pdx.rh.CN85.dnsmgr.net> Date: Sat, 22 Apr 2017 13:59:29 -0700 Cc: Ngie Cooper , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <3238ED82-1FAA-4E7C-81B9-A9E9E417E860@gmail.com> References: <201704222006.v3MK6fYX047692@pdx.rh.CN85.dnsmgr.net> To: rgrimes@freebsd.org X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Apr 2017 20:59:32 -0000 --Apple-Mail=_FE4CD735-896B-4905-8281-979374D404D9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Apr 22, 2017, at 13:06, Rodney W. Grimes = wrote: >=20 >> Author: ngie >> Date: Sat Apr 22 20:00:52 2017 >> New Revision: 317290 >> URL: https://svnweb.freebsd.org/changeset/base/317290 >>=20 >> Log: >> Fix -Wimplicit-function-declaration compilation warning by moving = libgeom.h >> #include below the stdio.h #include. >>=20 >> gctl_dump(3) needs stdio.h, per reasoning noted in r317289. >>=20 >> MFC after: 5 weeks >> PR: 218809 >> Submitted by: Chang-Hsien Tsai >> Sponsored by: Dell EMC Isilon >>=20 >> Modified: >> head/tools/regression/geom_gpt/test.c >>=20 >> Modified: head/tools/regression/geom_gpt/test.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/tools/regression/geom_gpt/test.c Sat Apr 22 19:32:23 2017 = (r317289) >> +++ head/tools/regression/geom_gpt/test.c Sat Apr 22 20:00:52 2017 = (r317290) >> @@ -29,12 +29,12 @@ __FBSDID("$FreeBSD$"); >>=20 >> #include >> #include >> -#include >> #include >> #include >> #include >> #include >> #include >> +#include > #include /* This is not in alphabetic order per r317289 = */ >>=20 >> struct retval { >> struct retval *retval; >=20 > Might it be a good idea to mark this in the test.c file as to why > these are not sorted in order to prevent regressions of this in > the future? Please see r317289. There was an omission in the documentation that = allowed this to happen. This also won=E2=80=99t happen again given that the test is now being = compiled with WARNS?=3D 6 :). -Ngie --Apple-Mail=_FE4CD735-896B-4905-8281-979374D404D9 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY+8QxAAoJEPWDqSZpMIYVg3oQAJXWvqhBMF2vVI9deaeRO1OR op1hutymdCABzoQBME+7sVHYZLxCPFBqShtEu5/1TPBaIBKlnVx2cFjKstAvyeaj 7j1+qiO+xh4x6FpknZUNf380A8P9R5zk5o9ZKx6SBAQvGZHHgs7JSXdWyhsMaAcq DHejMJp6nut/nuy5h2PSE4T97n3YgpdIOeiLVAGaYamdkvwht3I2uN6grB6GhDPy NjN9zUBVXA3Z0rNU+WoJQtVnTgtPUVXu++GJxKpg4zyHNwvJ1HqsISUcvD/QwXlB UFpLifVUUNM13rfC7q64tHNu7WVsDOlzI9c7MtlsEO2lqqCDHh49Ie6NaXVnRD5p E0tQjlTlU//Y0JO2AkIup+fgoFqEt0CrkVbvKe+RgmifeaVrHQd4v1KFNF9iz77U pvk8PKNFu/fNFmqUj1TulNl5yikuFsRj4tpD1iJSllrJgp35UfTDWZvU+4txT8kr 5+VldmKnsRWg/z4JUwYsE4whyyPfzSDVyh99xy/jJKmETxbocv7maDOvYYVZeWu1 b5tgfDXGU5AYZy1gLZxXTgNb+qf14USyOxB0cAkS5ygDOIFKDkYS3384N5V46+/Q MAleFCfz8sJzXMzoTIoxm6+EqSeM6jVxRS8e3nk1YnpvNPTsSaxSugottRgs7iNv /AvAB7IoJLNfgYo8yFvI =ltO5 -----END PGP SIGNATURE----- --Apple-Mail=_FE4CD735-896B-4905-8281-979374D404D9--