From owner-freebsd-hackers@FreeBSD.ORG Thu Nov 14 21:32:37 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D70E7541; Thu, 14 Nov 2013 21:32:37 +0000 (UTC) Received: from smtp.btshosting.co.uk (mx-2.btshosting.co.uk [IPv6:2a01:4f8:121:2403:2::]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 64E752FC7; Thu, 14 Nov 2013 21:32:37 +0000 (UTC) Received: from [192.168.1.65] (unknown [94.12.20.243]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by svr06-mx.btshosting.co.uk (Postfix) with ESMTPSA id DCA614325B; Thu, 14 Nov 2013 21:32:27 +0000 (UTC) Message-ID: <52854161.6080104@FreeBSD.org> Date: Thu, 14 Nov 2013 21:32:17 +0000 From: Jase Thew Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: John Baldwin , freebsd-hackers@freebsd.org Subject: Re: Re: Fix MNAMELEN or reimplement struct statfs References: <51B3B59B.8050903@erdgeist.org> <201306101152.17966.jhb@freebsd.org> In-Reply-To: <201306101152.17966.jhb@freebsd.org> X-Enigmail-Version: 1.6 OpenPGP: id=3F9B9617; url=pool.sks-keyservers.net Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WndSvNix6WnTdCfV7fNso5ASebNPhDBXN" Cc: mdf@freebsd.org, Dirk Engling X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Nov 2013 21:32:38 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WndSvNix6WnTdCfV7fNso5ASebNPhDBXN Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/06/2013 16:52, John Baldwin wrote: > On Saturday, June 08, 2013 9:36:27 pm mdf@freebsd.org wrote: >> On Sat, Jun 8, 2013 at 3:52 PM, Dirk Engling w= rote: >> >>> The arbitrary value >>> >>> #define MNAMELEN 88 /* size of on/from name bufs = */ >>> >>> struct statfs { >>> [...] >>> char f_mntfromname[MNAMELEN];/* mounted filesystem */ >>> char f_mntonname[MNAMELEN]; /* directory on which mounted= */ >>> }; >>> >>> currently bites us when trying to use poudriere with errors like >>> >>> 'mount: tmpfs: File name too long' >>> >>> >>> /poudriere/data/build/91_RELEASE_amd64-REALLY-REALLY-LONG- > JAILNAME/ref/wrkdirs >>> >>> The topic has been discussed several times since 2004 and has been >>> postponed each time, the last time when it hit zfs users: >>> >>> http://lists.freebsd.org/pipermail/freebsd-fs/2010-March/007974.html >>> >>> So I'd like to point to the calendar, it's 2013 already and there's >>> still a static arbitrary (and way too low) limit in one of the core >>> areas of the vfs code. >>> >>> So I'd like to bump the issue and propose either making f_mntfromname= a >>> dynamic allocation or just increase MNAMELEN, using 10.0 as water she= d. >>> >> >> Gleb Kurtsou did this along with the ino64 GSoC project. Unfortunatel= y, >> both he and I hit ENOTIME due to the job that pays the bills and it's= >> never made it back to the main repository. >> >> IIRC, though, the only reason for doing it with 64-bit ino_t is that h= e'd >> already finished changing the stat/dirent ABI so what was one more. I= >> think he went with 1024 bytes, which also necessitated not allocating >> statfs on the stack for the kernel. >=20 > He also fixed a few other things since changing this ABI is so invasive= > IIRC. This really is the right fix for this. Is it in an svn branch=20 > that can be updated and a new patch generated? >=20 Hi folks, Has there been any progress on addressing this issue? With the advent of pkgng / poudriere, this limitation is really becoming a frustrating probl= em. --=20 Jase Thew jase@FreeBSD.org FreeBSD Ports Committer --WndSvNix6WnTdCfV7fNso5ASebNPhDBXN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQJ8BAEBCgBmBQJShUFrXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRGNzY3ODIxQkE1MTQ4MjNFQ0RGNUM3QkRE NEU2NUM4QkZGMUMzODI5AAoJENTmXIv/HDgp/4QP/RyhATKVUf7H6jyrZhb+tCeV Li1rJ4w8Z5fK7C9vjqfl06sLezm/fvZb7Sk5GViP/LcvqKYjjCdheq+bdFikpQkT DbTNZEZAW8qDvEG/wpiShim+xahOhn6wJwC24ctrMw+ICvMbsUiol0rXu+NNEejA uA38yJ+J6MrrJklSSj+bVXcTSWrsSXFZCDalV6aF+nTdH4ImV4vsO3liSQvEIU8s OteJgpSVgruJrPY/7Pxe9t943KAbuWNG1guH0dD+mxH/9cgEDzttrvGXVBhYMDbH 9gy2KV4mr5RK8cCsDjwXgkXjPn51y63W6X6vVTo25WDIwQhDKMM4YE57LUOFG+s0 ykjh2fWgWJrtVyKpBVx+ikDOnPS6S6lKS3ucKQJHfRuN2SXyUVGudMbAcMUuTsz/ Hoy3IIQW2o1rDMtmrSx4beXCV9cd/BCNM0Q2ESIQcQQXD76Bp4qEXns+tNhSR3SS KtF7hGWWjxAicUzm8mc1UyL6IQgW0TIVvbEbGRkiNqdL5mNj4laaWE720kFB7BDl kK7reJ0500YKOjgAdZK7ZgcSlMRZU42eh09YkYZxdIzREFPAz86CNu76hFa7b6gX sAf/VRC0aeF1sjCpvD9VnOECTs5KbTOOfWeLsLwnhqj0xfSnEHoka2ssYmVBBvyP /qehrfqbOCKrGOfwzYU7 =78eZ -----END PGP SIGNATURE----- --WndSvNix6WnTdCfV7fNso5ASebNPhDBXN--