From owner-cvs-all Fri Jun 1 9:14:55 2001 Delivered-To: cvs-all@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id 05BD437B42C; Fri, 1 Jun 2001 09:14:51 -0700 (PDT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.11.3/8.11.3) with ESMTP id f51GEnW63142; Fri, 1 Jun 2001 12:14:50 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20010531231614.A64344@dragon.nuxi.com> References: <200106010007.f5107AY14009@freefall.freebsd.org> <20010531231614.A64344@dragon.nuxi.com> Date: Fri, 1 Jun 2001 12:14:48 -0400 To: obrien@FreeBSD.org, Garance A Drosehn From: Garance A Drosihn Subject: Re: cvs commit: src/bin/sh eval.c Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Content-Type: text/plain; charset="us-ascii" ; format="flowed" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 11:16 PM -0700 5/31/01, David O'Brien wrote: >On Thu, May 31, 2001, Garance A Drosehn wrote: > > Modified files: >> bin/sh eval.c >> Log: > > Fix how /bin/sh handles 'for' and 'case' statements when it is > > called to do errexit (-e) processing. > >Was this reviewed by cracauer? He has been doing the care and >feeding of ash for along time and he really up on the subtleties >of the various standards that address `sh'. I sent a message on Monday, but haven't received a reply. And the more I've looked at the code, the more I'm sure that the fix I went with is appropriate. The patch also includes comments explaining exactly why it's appropriate, for the next person who looks at the routine in question. -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message