From owner-cvs-all@FreeBSD.ORG  Sun Jan 25 04:36:24 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id AE90216A4CF; Sun, 25 Jan 2004 04:36:24 -0800 (PST)
Received: from smtp.des.no (flood.des.no [217.116.83.31])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 020EB43D39; Sun, 25 Jan 2004 04:36:21 -0800 (PST)
	(envelope-from des@des.no)
Received: by smtp.des.no (Pony Express, from userid 666)
	id DD8DE530A; Sun, 25 Jan 2004 13:36:19 +0100 (CET)
Received: from dwp.des.no (des.no [80.203.228.37])
	by smtp.des.no (Pony Express) with ESMTP
	id 8D0205309; Sun, 25 Jan 2004 13:36:10 +0100 (CET)
Received: by dwp.des.no (Postfix, from userid 2602)
	id 6834733C9A; Sun, 25 Jan 2004 13:36:10 +0100 (CET)
To: Jeff Roberson <jeff@FreeBSD.org>
References: <200401250821.i0P8LkBC072150@repoman.freebsd.org>
From: des@des.no (Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=)
Date: Sun, 25 Jan 2004 13:36:10 +0100
In-Reply-To: <200401250821.i0P8LkBC072150@repoman.freebsd.org> (Jeff
 Roberson's message of "Sun, 25 Jan 2004 00:21:46 -0800 (PST)")
Message-ID: <xzpd698qk79.fsf@dwp.des.no>
User-Agent: Gnus/5.090024 (Oort Gnus v0.24) Emacs/21.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-Spam-Checker-Version: SpamAssassin 2.61 (1.212.2.1-2003-12-09-exp) on 
	flood.des.no
X-Spam-Level: ss
X-Spam-Status: No, hits=2.6 required=5.0 tests=RCVD_IN_DYNABLOCK,
	RCVD_IN_SORBS autolearn=no version=2.61
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern sched_4bsd.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Jan 2004 12:36:24 -0000

Jeff Roberson <jeff@FreeBSD.org> writes:
>   Log:
>    - Correct function names listed in KASSERTs.  These were copied from o=
ther
>      code and it was sloppy of me not to adjust these sooner.

suggestions based on my experience with KASSERTs:

1) don't include the function name in panic strings as the backtrace
   already provides that information (and more)

2) if you must include the function name, use %s() and __func__ to
   avoid getting it wrong.

DES
--=20
Dag-Erling Sm=F8rgrav - des@des.no