Date: Thu, 22 Oct 2015 11:42:31 -0700 From: John Baldwin <jhb@freebsd.org> To: Bryan Drewery <bdrewery@freebsd.org> Cc: Baptiste Daroussin <bapt@freebsd.org>, src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: Re: svn commit: r289692 - projects/zfsd/head/lib/libdevdctl Message-ID: <2055961.NdPaavVgjo@ralph.baldwin.cx> In-Reply-To: <562825BB.7090401@FreeBSD.org> References: <201510211244.t9LCipMj060521@repo.freebsd.org> <1542570.1xCFep8lJG@ralph.baldwin.cx> <562825BB.7090401@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, October 21, 2015 04:54:35 PM Bryan Drewery wrote: > On 10/21/2015 4:47 PM, John Baldwin wrote: > > On Thursday, October 22, 2015 12:50:48 AM Baptiste Daroussin wrote: > >> On Wed, Oct 21, 2015 at 09:52:34AM -0700, John Baldwin wrote: > >>> On Wednesday, October 21, 2015 12:44:51 PM Baptiste Daroussin wrote: > >>>> Author: bapt > >>>> Date: Wed Oct 21 12:44:51 2015 > >>>> New Revision: 289692 > >>>> URL: https://svnweb.freebsd.org/changeset/base/289692 > >>>> > >>>> Log: > >>>> Change SHLIB_MAJOR to 0 > >>>> > >>>> The lib hasn't been released yet so need to start having a first version with .so.5 > >>>> > >>>> Sponsored by: Gandi.net > >>> > >>> OTOH, this means more work in the future as any system-wide shlib bumps have > >>> to bump this manually. I think it is best to just use the default shlib major > >>> for new libraries. The extra maintenance load in the future isn't worth having > >>> a .0 IMO. > >>> > >> Right, but why is the default starting at .5 that does not sound right to me? > >> any explaination I missed? > > > > There's a global at lib/Makefile.inc that re@ has bumped on each major release > > (in the past), and is currently at 5. It hasn't been bumped since 8.0 actually > > since we are now more selective about bumps, but that does explain why it is 5 > > instead of 0. > > Auto bumping it without justification from ABI changes sounds odd. I'm > glad it is not now. Symbol versioning should be used instead where > possible as well as the benefits are greater for compat, as you know. The auto bumping was mostly from before we had symbol versioning in place. Note that we only version a small number of our libraries (mostly libc and libthr). OTOH, most other libraries do not see much ABI churn. However, my libkvm changes would benefit from symbol versioning if it were present. However, you have to do a bump when you enable versioning and I can add a kvm_read2() without having to bump, so I've gone for the latter. I still think library Makefiles should just use the default SHLIB_MAJOR though. One hopes we don't have to bump it again, but it is not completely beyond the pale. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2055961.NdPaavVgjo>