From owner-svn-src-projects@FreeBSD.ORG Mon Mar 4 20:41:07 2013 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 4771E1E4; Mon, 4 Mar 2013 20:41:07 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-ia0-x22d.google.com (mail-ia0-x22d.google.com [IPv6:2607:f8b0:4001:c02::22d]) by mx1.freebsd.org (Postfix) with ESMTP id D036D12B5; Mon, 4 Mar 2013 20:41:06 +0000 (UTC) Received: by mail-ia0-f173.google.com with SMTP id h37so5229148iak.4 for ; Mon, 04 Mar 2013 12:41:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=Szh84LJkzeJM30CgT/1Aa8FOpYeruHZyVyrCBYYQNXM=; b=ESSW5AHBb56iUtKTUNQJVOJ4Wp3Czm7PmamfPY/ZASotnvJIIeI5OM+m7qa2T7yvtu MMWa1p83QkR08KRQ2Br/RlJvjKtftP/pFDkO2OLJaOOSpxATCMNZZGQMQkNp4y7vzcgJ 7kbbnOLoC1xGkHuXvj3L309jkg6T60I+MFkvKlVQWQTp1HvGtNAObNcW94VdwWwg4lUR kIPEUzeF8gBw7PSasOFNVBogmPz2DNDiEEgRY+bJ7peq6jwYb9aO+qvtCdMP7wGRViSe tVxBGkhtSX14RDgzgvB7co2nlMyNHq2cgxviY/MN8mrqeIjga1hqLmJ67HrUpwMNYXHS KVMg== MIME-Version: 1.0 X-Received: by 10.50.203.3 with SMTP id km3mr3811633igc.64.1362429666415; Mon, 04 Mar 2013 12:41:06 -0800 (PST) Sender: asmrookie@gmail.com Received: by 10.42.117.134 with HTTP; Mon, 4 Mar 2013 12:41:05 -0800 (PST) In-Reply-To: <201303041521.06557.jhb@freebsd.org> References: <201303031339.r23DdsBU047737@svn.freebsd.org> <201303041040.41845.jhb@freebsd.org> <201303041521.06557.jhb@freebsd.org> Date: Mon, 4 Mar 2013 21:41:05 +0100 X-Google-Sender-Auth: Z_TCpm6R_3CYRpAchSEKnHzPLAs Message-ID: Subject: Re: svn commit: r247710 - projects/calloutng/sys/kern From: Attilio Rao To: John Baldwin Content-Type: text/plain; charset=UTF-8 Cc: Davide Italiano , svn-src-projects@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Mar 2013 20:41:07 -0000 On Mon, Mar 4, 2013 at 9:21 PM, John Baldwin wrote: > On Monday, March 04, 2013 3:17:30 pm Davide Italiano wrote: >> On Mon, Mar 4, 2013 at 4:40 PM, John Baldwin wrote: >> > On Sunday, March 03, 2013 8:39:54 am Davide Italiano wrote: >> >> Author: davide >> >> Date: Sun Mar 3 13:39:54 2013 >> >> New Revision: 247710 >> >> URL: http://svnweb.freebsd.org/changeset/base/247710 >> >> >> >> Log: >> >> - Use TRUE/FALSE in lieu of 0/1 for boolean_t variables. >> > >> > We have stdbool in the kernel. Why not use that instead of the Machish >> > boolean_t? >> > >> > -- >> > John Baldwin >> >> It was originally int, and a couple of days ago Attilio suggested to >> move to 'boolean_t'. >> Honestly, I didn't argue due to the relative little relevance of the >> change, but actually I find the type change more explicative. >> I have no strong objections to change it again (in particular because >> I think you're suggesting to use bool to be C99 compliant, feel free >> to correct me if I'm wrong). >> >> While here. After closer looking I realized boolean_t is widely used >> in the kernel (e.g. sys/kern/). Is this just a common error or is >> there something I'm missing? > > No, it's just older and bool is C99 as you noticed. I had thought that > boolean_t was largely regulated to code from Mach (i.e. sys/vm) and that > we should use bool for new code. Actually boolean_t is much more widespread in our kernel than the C99 variant. Moreover style(9) doesn't advertise it either, neither the necessity to conform to library defined C99 features (even if present in the C99 standard, _Bool is still defined in stdbool.h which is an header not present in our kernel). I wonder how much style(9) can change over the time. Maybe it is time to add/update few rules to better comply with new standard adds. Attilio -- Peace can only be achieved by understanding - A. Einstein