From owner-freebsd-bugs@FreeBSD.ORG Mon Aug 31 11:30:06 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7191810656B9 for ; Mon, 31 Aug 2009 11:30:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3460B8FC18 for ; Mon, 31 Aug 2009 11:30:06 +0000 (UTC) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n7VBU6Oo094196 for ; Mon, 31 Aug 2009 11:30:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n7VBU6KD094195; Mon, 31 Aug 2009 11:30:06 GMT (envelope-from gnats) Resent-Date: Mon, 31 Aug 2009 11:30:06 GMT Resent-Message-Id: <200908311130.n7VBU6KD094195@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Patroklos Argyroudis Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AF1F51065672 for ; Mon, 31 Aug 2009 11:23:19 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 9E0B68FC1D for ; Mon, 31 Aug 2009 11:23:19 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n7VBNJRM013610 for ; Mon, 31 Aug 2009 11:23:19 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n7VBNJu1013609; Mon, 31 Aug 2009 11:23:19 GMT (envelope-from nobody) Message-Id: <200908311123.n7VBNJu1013609@www.freebsd.org> Date: Mon, 31 Aug 2009 11:23:19 GMT From: Patroklos Argyroudis To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/138390: NULL pointer dereference in gif_input() in file sys/net/if_gif.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Aug 2009 11:30:06 -0000 >Number: 138390 >Category: kern >Synopsis: NULL pointer dereference in gif_input() in file sys/net/if_gif.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Aug 31 11:30:05 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Patroklos Argyroudis >Release: 8.0-CURRENT >Organization: census, inc >Environment: N/A >Description: There is a possible NULL pointer dereference in gif_input() in file sys/net/if_gif.c at line 510. The check against NULL at line 515 should be before the dereference of ifp at line 510. >How-To-Repeat: N/A >Fix: Patch attached. Patch attached with submission follows: --- ./sys/net/if_gif.c.orig 2009-08-28 16:49:31.000000000 +0300 +++ ./sys/net/if_gif.c 2009-08-28 16:50:59.000000000 +0300 @@ -507,7 +507,7 @@ struct ifnet *ifp; { int isr, n; - struct gif_softc *sc = ifp->if_softc; + struct gif_softc *sc; struct etherip_header *eip; struct ether_header *eh; struct ifnet *oldifp; @@ -518,6 +518,7 @@ return; } + sc = ifp->if_softc; m->m_pkthdr.rcvif = ifp; #ifdef MAC >Release-Note: >Audit-Trail: >Unformatted: