From owner-freebsd-ports-bugs@freebsd.org Sat Aug 26 15:18:08 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0B793DD44AF for ; Sat, 26 Aug 2017 15:18:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E18DA6EDF7 for ; Sat, 26 Aug 2017 15:18:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v7QFI7Cl041396 for ; Sat, 26 Aug 2017 15:18:07 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 221755] [new port] graphics/tesseract-devel: Development version of tesseract ocr engine from github repository. Date: Sat, 26 Aug 2017 15:18:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tobik@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tobik@freebsd.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status assigned_to cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Aug 2017 15:18:08 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221755 Tobias Kortkamp changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Open Assignee|freebsd-ports-bugs@FreeBSD. |tobik@freebsd.org |org | CC| |tobik@freebsd.org --- Comment #1 from Tobias Kortkamp --- Hi, thanks for your submission. I have done a short review and found a couple of issues. This port appears to install files in the same location as graphics/tesseract. You might need to add (see [0]) CONFLICTS=3D tesseract-[0-9]* XPORTVERSION=3D 4.0.0a ... XUSE_GITHUB=3D yes XGH_ACCOUNT=3D ${PORTNAME}-ocr XGH_TAGNAME=3D 1e3bf29 Since this is a development version (i.e. you use a commit between two releases) follow the procedure in [1] instead to set DISTVERSION{,SUFFIX,PREFIX} accordingly (you do not need to set GH_TAGNAME in this case). It's best to not invent our own version numbers. (This applies to your other submissions from bug #221756 and bug #221757 too.) For commit 1e3bf29 this is=20 DISTVERSION=3D 4.00.00dev-620 DISTVERSIONSUFFIX=3D -g1e3bf29c ... USE_GITHUB=3D yes GH_ACCOUNT=3D tesseract-ocr XLICENSE=3D APACHE20 Add LICENSE_FILE=3D ${WRKSRC}/COPYING Xpost-patch: X @${REINPLACE_CMD} -e 's|-O2 -DNDEBUG|-O3 -DNDEBUG -march=3Dnative|' ${WRKSRC}/configure.ac This looks wrong, why replace it with -O3 -march=3Dnative? Ports should not set their own optimization flags (see [2]) and should respect CFLAGS, CXXFLAGS, ... Xbin/ambiguous_words Xbin/classifier_tester Xbin/cntraining Xbin/combine_lang_model Xbin/combine_tessdata Xbin/dawg2wordlist Xbin/lstmeval Xbin/lstmtraining Xbin/mftraining Xbin/set_unicharset_properties Xbin/shapeclustering Xbin/tesseract Xbin/text2image Xbin/unicharset_extractor Xbin/wordlist2dawg pkg-plist is wrong. Some of these are not installed without TOOLS which means the option is broken at the moment. What happened to the man pages? graphics/tesseract has them and I see the sources for them in ${WRKSRC}/doc. Can they be generated and installed too? [0] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/conflict= s.html [1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile= -distfiles.html#makefile-master_sites-github-ex5 [2] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-cfl= ags.html --=20 You are receiving this mail because: You are the assignee for the bug.=