From owner-svn-src-head@freebsd.org Wed Jun 20 18:03:04 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AA36E1001854; Wed, 20 Jun 2018 18:03:04 +0000 (UTC) (envelope-from jonlooney@gmail.com) Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1D8446B035; Wed, 20 Jun 2018 18:03:04 +0000 (UTC) (envelope-from jonlooney@gmail.com) Received: by mail-wm0-f41.google.com with SMTP id v16-v6so923907wmh.5; Wed, 20 Jun 2018 11:03:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3gbLfR7wBWWCwstijfaRR85j1Y6fi9dJvbkXPKIqwEk=; b=LSbSDLgRnTH9EBrG6ru8rBPGm6M414EKY9Fhapm6QM3MHtPUvgHFX7deSAhfQz98bx 77wZfE8WXsj9Uq2hcYvPipQ4f4s1y6PBsx9NbVn6Ey1x0I8OWrvpIYfXf+nkTzj6y8l1 gR5e5n7qF/HS97ncGW+HN73xtvf7t8vPIvw2VbyfAcWosHq+93/1+oiivPfN7jkk9Wd4 d5Twp+pxLDepaLK41IDD/hFWOjFzFofXp5fRK8/XA+LuyuyEdhaAT0KGFMShU2i+ex5Y Vw6pXmQsmOqFFfOvrl00ZDBopFhSuchmN7edQUbVDRY1HE9w6slGsDhEuSmiKLKzzSdw vr+Q== X-Gm-Message-State: APt69E0nR8ifXBPpk8qRok9qRhF4DsqDP1sFoPu+xXitdmVE2ovxCo7h ONPY2ngp8UCFH702G3vnVHDzc+T0iSI= X-Google-Smtp-Source: ADUXVKLeRutQu6lguYX8vtUci3hUQNr0NA4BFQ9TT1rZ8QZytGt6PmCT/3JFjUXY0361iYeKUXOjwQ== X-Received: by 2002:a50:88a6:: with SMTP id d35-v6mr19385630edd.239.1529517777254; Wed, 20 Jun 2018 11:02:57 -0700 (PDT) Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com. [74.125.82.46]) by smtp.gmail.com with ESMTPSA id h15-v6sm1175378edr.4.2018.06.20.11.02.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jun 2018 11:02:57 -0700 (PDT) Received: by mail-wm0-f46.google.com with SMTP id 69-v6so1099438wmf.3; Wed, 20 Jun 2018 11:02:56 -0700 (PDT) X-Received: by 2002:a1c:c687:: with SMTP id w129-v6mr2591030wmf.66.1529517776793; Wed, 20 Jun 2018 11:02:56 -0700 (PDT) MIME-Version: 1.0 References: <201806200108.w5K18sIR050132@repo.freebsd.org> <96021.1529475664@kaos.jnpr.net> <17033.1529508519@kaos.jnpr.net> <1529510299.24573.5.camel@freebsd.org> In-Reply-To: From: "Jonathan T. Looney" Date: Wed, 20 Jun 2018 11:02:45 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r335402 - head/sbin/veriexecctl To: hackagadget@gmail.com Cc: Conrad Meyer , Ian Lepore , "Simon J. Gerraty" , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2018 18:03:05 -0000 On Wed, Jun 20, 2018 at 9:49 AM Stephen Kiernan wrote: > And I was working on those sets of changes, when work and family didn't > steal away time. I was told that some discussion happened at BSDCan this > year in such that veriexec should go in as-is so it would be there, which is why > the commit happened (given the review was approved to land back in January.) I will readily admit that I was probably the source of this. My reasoning was fairly simple: when a review has been open for over a year with no action, it seems like the submitter should be able to commit it without waiting for more review, if they are confident in their change. I stand by that (and, in fact, would substitute something shorter for "over a year"). (Of course, if the submitter has other reasons for delaying the commit, that's their prerogative, and I wasn't intending to push Steve to commit this before he was ready.) Jonathan