From owner-dev-commits-src-main@freebsd.org Sun Apr 18 06:00:43 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 432845F1FD8; Sun, 18 Apr 2021 06:00:43 +0000 (UTC) (envelope-from pho@holm.cc) Received: from relay05.pair.com (relay05.pair.com [216.92.24.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FNK7H142Wz4W4j; Sun, 18 Apr 2021 06:00:42 +0000 (UTC) (envelope-from pho@holm.cc) Received: from x8.osted.lan (unknown [80.208.71.94]) by relay05.pair.com (Postfix) with ESMTP id EF9A71A28CE; Sun, 18 Apr 2021 02:00:41 -0400 (EDT) Received: from x8.osted.lan (localhost [127.0.0.1]) by x8.osted.lan (8.15.2/8.15.2) with ESMTPS id 13I60fwW048961 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 18 Apr 2021 08:00:41 +0200 (CEST) (envelope-from pho@x8.osted.lan) Received: (from pho@localhost) by x8.osted.lan (8.15.2/8.15.2/Submit) id 13I60fpq048960; Sun, 18 Apr 2021 08:00:41 +0200 (CEST) (envelope-from pho) Date: Sun, 18 Apr 2021 08:00:40 +0200 From: Peter Holm To: Richard Scheffenegger Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to sack.revised, and enable by default Message-ID: <20210418060040.GA48834@x8.osted.lan> References: <202104171350.13HDoPQL025776@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202104171350.13HDoPQL025776@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4FNK7H142Wz4W4j X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Apr 2021 06:00:43 -0000 On Sat, Apr 17, 2021 at 01:50:25PM +0000, Richard Scheffenegger wrote: > The branch main has been updated by rscheff: > > URL: https://cgit.FreeBSD.org/src/commit/?id=d1de2b05a001d3d80f633f576f4909c2686dda3d > > commit d1de2b05a001d3d80f633f576f4909c2686dda3d > Author: Richard Scheffenegger > AuthorDate: 2021-04-17 12:59:30 +0000 > Commit: Richard Scheffenegger > CommitDate: 2021-04-17 12:59:45 +0000 > > tcp: Rename rfc6675_pipe to sack.revised, and enable by default > > As full support of RFC6675 is in place, deprecating > net.inet.tcp.rfc6675_pipe and enabling by default > net.inet.tcp.sack.revised. > > Reviewed By: #transport, kbowling, rrs > Sponsored by: NetApp, Inc. > Differential Revision: https://reviews.freebsd.org/D28702 > --- > share/man/man4/tcp.4 | 25 ++++++++++++++----------- > sys/netinet/cc/cc_cubic.c | 2 +- > sys/netinet/cc/cc_htcp.c | 2 +- > sys/netinet/cc/cc_newreno.c | 2 +- > sys/netinet/tcp_input.c | 11 +++-------- > sys/netinet/tcp_sack.c | 12 +++++++++--- > sys/netinet/tcp_var.h | 4 ++-- > 7 files changed, 31 insertions(+), 27 deletions(-) > > diff --git a/share/man/man4/tcp.4 b/share/man/man4/tcp.4 > index d01505e58427..cbb8021226fe 100644 > --- a/share/man/man4/tcp.4 Could this panic be related? 20210418 07:19:59 all (204/751): jumbo.sh panic: tcp_output: sack block to the left of una : -293976 cpuid = 3 time = 1618723234 KDB: stack backtrace: db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00e49b0550 vpanic() at vpanic+0x181/frame 0xfffffe00e49b05a0 panic() at panic+0x43/frame 0xfffffe00e49b0600 tcp_output() at tcp_output+0x27dc/frame 0xfffffe00e49b07c0 tcp_do_segment() at tcp_do_segment+0x32a3/frame 0xfffffe00e49b08b0 tcp_input() at tcp_input+0xbd5/frame 0xfffffe00e49b0a10 ip_input() at ip_input+0x194/frame 0xfffffe00e49b0aa0 swi_net() at swi_net+0x1a1/frame 0xfffffe00e49b0b20 ithread_loop() at ithread_loop+0x279/frame 0xfffffe00e49b0bb0 fork_exit() at fork_exit+0x80/frame 0xfffffe00e49b0bf0 fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe00e49b0bf0 --- trap 0, rip = 0, rsp = 0, rbp = 0 --- https://people.freebsd.org/~pho/stress/log/log0094.txt - Peter