From owner-svn-src-head@freebsd.org Sat Apr 15 16:24:56 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EF357D3F336; Sat, 15 Apr 2017 16:24:56 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pf0-x242.google.com (mail-pf0-x242.google.com [IPv6:2607:f8b0:400e:c00::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C18CF636; Sat, 15 Apr 2017 16:24:56 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pf0-x242.google.com with SMTP id c198so18918391pfc.0; Sat, 15 Apr 2017 09:24:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2yaTR6Gnn19Q6prbALa96dNw2DJuimhXJrBerbJngkA=; b=UAuJbTUg4t/bRt9rAWqxOc7jDH1OvJVZL7UGcsmU+O2ToIOWk+eYVCpoecvl1c7ioV /+TzHH60rG3k2YB6rRPsVBkKYg0WKNynudeH8Bf59UCg4jpoBpUVHMGtm1SqnP7yMMUl tQguPov9I4QFuEoJseB2RzPv0CHcqD4IrPqAEh6Owkq4fWseQZbTjpsdjPY2lG65DDw1 L9eNunnQQ4TezoZHr64uYcU/43Np+E3fjKdvOQkamZpxOR+aWQUf8rQCJpqWK6tOuHct MhbpLqa91wBNXHxN7K2lK+N0O4Ze2V5sLwmy+iDE94T6uaxSjM5Jl/IAHa2EKlbiNKNG dLLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=2yaTR6Gnn19Q6prbALa96dNw2DJuimhXJrBerbJngkA=; b=uXkFnbqPRBY8yOLcLPtgKso2B9JnQlULwXNTUuoJLsCNz/AyVKWKnzbcEDsYzF9vqe aQSJwmoT3S/7n1IQKvF+KVd1TESEfAszcB/h7POWhUhEUPst/kwiY8WagcQ1idXHqLsv dWjhQsxHqGTrzuycabryYUBfgoCRsICywBb4xdnMkZ4d2zE8yyG4OD0+kjSQ/1QTYpIr UKhOWUq/U2RANSOKqnwLFde13tCmav5MqYNuDi5FC8m35PEFtP5QNo5hobyMYYza5YEx W8KgHEFXRenWwnFGBXWx364w2gsqjGfq8ZNj7btVmPynpoKhtaYXMtzunMaAIC3zQSF8 pIoA== X-Gm-Message-State: AN3rC/6lxUFWP/WYFTnXJvtFSSCgfrqqGZivP0W7G4MOGKhvgLFi2qhy j+9OkJQAPSFPZg/lXLc= X-Received: by 10.99.114.80 with SMTP id c16mr3412472pgn.121.1492273496064; Sat, 15 Apr 2017 09:24:56 -0700 (PDT) Received: from raichu ([2604:4080:1102:0:ca60:ff:fe9d:3963]) by smtp.gmail.com with ESMTPSA id g5sm9370012pfe.12.2017.04.15.09.24.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Apr 2017 09:24:55 -0700 (PDT) Sender: Mark Johnston Date: Sat, 15 Apr 2017 09:24:51 -0700 From: Mark Johnston To: rgrimes@freebsd.org Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r316938 - head/sbin/savecore Message-ID: <20170415162437.GA89653@raichu> References: <20170415053729.GA76139@raichu> <201704150642.v3F6g41p010449@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201704150642.v3F6g41p010449@pdx.rh.CN85.dnsmgr.net> User-Agent: Mutt/1.8.0 (2017-02-23) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Apr 2017 16:24:57 -0000 On Fri, Apr 14, 2017 at 11:42:04PM -0700, Rodney W. Grimes wrote: > > On Fri, Apr 14, 2017 at 06:30:17PM -0700, Rodney W. Grimes wrote: > > > > The patch to add compression support is here and should largely still > > > > work: > > > > https://people.freebsd.org/~markj/patches/core-compression/20141110-kern_dump.diff > > > > > > > > I've been hesitant about pushing it forward: > > > > - The dump_write* APIs need some simplification after the addition of > > > > encrypted dump support and support for dumping to 4Kn drives. > > > > - I'm not sure how encryption should compose with compression. It seems > > > > intuitively obvious that we should compress before encrypting if the > > > > compression is to be of any use, but I don't know enough to know > > > > whether the compression might somehow compromise the effectiveness of > > > > the encryption. > > > > > > > > If anyone has some insight on the second of these two points, I'd > > > > appreciate hearing it. > > > > > > I have a large amount of reworking and modulization of the dump code > > > incuding intergration of your (markj) compressed dumps. Layer isnt > > > implemented but is in the plan. I should not of held off on the net > > > dump code as it got smashed by encrypted dumps, then again by > > > the libif'ing for all the Intel drives that had been netdump modified. > > > > > > Basically now starting over :-( > > > > Could you post your patches somewhere? I've been sitting on this (and > > the netdump patches, for which I have quite a few modifications) for far > > too long, and would like to finish them and get them in soon. I'll note > > that the netdump code posted a few years ago had some problems that are > > fixed in Isilon's version, which I'm working on rebasing on HEAD. In > > Isnt the code I rebaed in December to -12 your code from Isiolon???? I don't know exactly what code you're referring to. > Or tell me you handed me your patches to upstream, and then continued > to evolved the code without letting me know? Are YOUR patckes some > place public? I dont think mine are, but I do have a link in > http://people.freebsd.org/~rgrimes pointing to the other Netdump version > that I think is an old version of your code. I haven't changed the compression patch since I posted it a long time ago: https://people.freebsd.org/~markj/patches/core-compression/20141110-kern_dump.diff I've made a fairly large set of changes to the netdump code linked on your page. Some of the changes were motivated by the objections raised to the original set of patches. I currently don't have a working copy of my netdump patches against HEAD, but here are some internal patches: https://people.freebsd.org/~markj/patches/netdump/ A recent revision of the netdumpd code is here: https://github.com/markjdb/netdumpd