From owner-svn-src-all@freebsd.org Wed Feb 6 17:29:49 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8F68B14D9E82 for ; Wed, 6 Feb 2019 17:29:49 +0000 (UTC) (envelope-from will@firepipe.net) Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6DDC776184 for ; Wed, 6 Feb 2019 17:29:48 +0000 (UTC) (envelope-from will@firepipe.net) Received: by mail-qk1-x735.google.com with SMTP id x9so1154653qkf.0 for ; Wed, 06 Feb 2019 09:29:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=firepipe-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lDbqXr/eoSBPwNgBJa2f/so2vV4juU3i2pRhuUU2IaM=; b=d3ktz26SsTPVXAT7rVER1W8CwP/vwojaiDtx+haeB0V5bcwit8+Sbc+pY6AZ5JGJeb zw1rce6TldunPiIK5Y8lVsGsKuLfXfHPB+LDFgQCsCzt3JN2Nk/eWpPQTEZEDvrEcqgo esuX2Rh6YZhzzcmd8vvhKNhl6MbsaJ8arfpg4HFG1BrGuybqJFFPXW9yeJ4rfXC/ynFp kGpkpy70VNKpXakyCRPf+rhojBnKGXI13DlQeomgGV0AQ8UW6TXkrRYf5+NoP9yaDqHT 6qu1sOtbqwZq2pEB/Y+93xKFf4sOBVdU58b6SLz/8AUmvj6vJo4vt2k3tLeqiw1j1ElV N3aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lDbqXr/eoSBPwNgBJa2f/so2vV4juU3i2pRhuUU2IaM=; b=aIKYiA/F7dmM2adJxSbn76+D/8HoB63+DAlwwdA3SCdQhJQmx/XyX1pzKLK7CG4je/ I9rV8H/lrfmyO38lf9RC/0ioKAREWFR52royIwz38o/lvNa0atlqkVcEcMDIkMte/mgu ddd0KFMRXqR6sQqWHAsWptwhAqYLAEuHkC+VwBiHbU5PefylZAQUfsY32Ox+YrqSIupc JLeYYKtDPf5NDFAQgEEo4f7E02glaIVGrfssjvWNVO0JAeCCFv4+RfjJdJxNuT8/gTM6 VwqB222HhyHd8Iw058xwCkjtbNaU47sDMWJ4xAmt25Sd4jSdN+QytfyvsvTZmLcwRuR6 qz3w== X-Gm-Message-State: AHQUAuZqoi84GyjEHxpszVw6c07EUXy1PRiHZp/B/D7MgPa2ipG3KG82 yW1PPzhc7dnuGGiXLyYxjZfbVP/wYR8AkwlMhuTb2eJv5/M= X-Google-Smtp-Source: AHgI3IZPDIb7JMiW080JquuFQICFnq8r2QIQ98tVGCUmIqjwqUk7qdE65Bal2o1gZz+tbwAJWgDPHuEvMZwGAHX7Gu0= X-Received: by 2002:a37:de19:: with SMTP id h25mr8519442qkj.146.1549474187722; Wed, 06 Feb 2019 09:29:47 -0800 (PST) MIME-Version: 1.0 References: <201711112330.vABNUwXC077395@repo.freebsd.org> <20190205202145.A1080@besplex.bde.org> <20190206024025.X3175@besplex.bde.org> In-Reply-To: <20190206024025.X3175@besplex.bde.org> From: Will Andrews Date: Wed, 6 Feb 2019 11:29:32 -0600 Message-ID: Subject: Re: svn commit: r325728 - head/lib/libkvm To: Bruce Evans Cc: Ed Maste , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 6DDC776184 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=firepipe-net.20150623.gappssmtp.com header.s=20150623 header.b=d3ktz26S X-Spamd-Result: default: False [-5.99 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[firepipe-net.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[firepipe.net]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[firepipe-net.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[aspmx.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[5.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.93)[-0.928,0]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[optusnet.com.au]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; IP_SCORE(-2.76)[ip: (-9.24), ipnet: 2607:f8b0::/32(-2.50), asn: 15169(-1.96), country: US(-0.07)] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2019 17:29:49 -0000 On Tue, Feb 5, 2019 at 10:25 AM Bruce Evans wrote: > Signed kp_offset seems wrong. Apart from it not reaching the top of 64- > bit address spaces, adding unsigned kp_len to it gives an unsigned type. > It's appropriate, because in this context, we return page information including addresses that would be valid pointer references, but are not included in the core file. Minidumps omit large numbers of physical pages, so calls to kvm_walk_pages() will generate large numbers of kvm_page instances that have an offset of -1. --Will.