From owner-svn-ports-head@freebsd.org  Fri Jul 22 04:46:58 2016
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0B182BA161B;
 Fri, 22 Jul 2016 04:46:58 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id E3EDF1571;
 Fri, 22 Jul 2016 04:46:57 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id E2C041A90; Fri, 22 Jul 2016 04:46:57 +0000 (UTC)
Date: Fri, 22 Jul 2016 04:46:57 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Kris Moore <kmoore@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r418889 - in head/deskutils: . copyq
Message-ID: <20160722044657.GC37437@FreeBSD.org>
References: <201607211847.u6LIluTh087613@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201607211847.u6LIluTh087613@repo.freebsd.org>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jul 2016 04:46:58 -0000

On Thu, Jul 21, 2016 at 06:47:56PM +0000, Kris Moore wrote:
> New Revision: 418889
> URL: https://svnweb.freebsd.org/changeset/ports/418889
> 
> Log:
>   CopyQ is advanced clipboard manager with editing and scripting features.
>   
>   WWW: https://github.com/hluk/CopyQ
> 
> [...]
> +USE_XORG+=	x11 xfixes xtst

What's the reason for += here?

> +USE_QT5=        core gui network svg multimedia imageformats \

Spaces were used in this line instead of proper tab.

> +USE_GL+=	gl

Bogus += again.

> +USES=           qmake

Spaces again; also it's better to place more generic USES *before* specific
USE_FOO knobs.

> +PLIST_FILES=	bin/copyq

PLIST-related knobs should be among the last ones (after USE* knobs, but
before OPTIONS* knobs).

> +do-install:
> +	${INSTALL_PROGRAM} ${WRKSRC}/copyq ${STAGEDIR}${PREFIX}/bin/copyq

Last component of destination is redundant (${STAGEDIR}${PREFIX}/bin would
be enough).

./danfe