From owner-p4-projects@FreeBSD.ORG  Fri Jul 13 12:22:30 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4134016A4AB; Fri, 13 Jul 2007 12:22:30 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 0290E16A40F;
	Fri, 13 Jul 2007 12:22:30 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.freebsd.org (Postfix) with ESMTP id A32A613C4A5;
	Fri, 13 Jul 2007 12:22:29 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l6DCMJHM003289;
	Fri, 13 Jul 2007 08:22:24 -0400 (EDT) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: "M. Warner Losh" <imp@bsdimp.com>
Date: Fri, 13 Jul 2007 08:08:54 -0400
User-Agent: KMail/1.9.6
References: <200707090405.l69456Mw026331@repoman.freebsd.org>
	<20070710.112123.-345495745.imp@bsdimp.com>
In-Reply-To: <20070710.112123.-345495745.imp@bsdimp.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200707130808.55708.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]);
	Fri, 13 Jul 2007 08:22:25 -0400 (EDT)
X-Virus-Scanned: ClamAV 0.88.3/3656/Fri Jul 13 07:24:51 2007 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: perforce@freebsd.org, cnst@freebsd.org
Subject: Re: PERFORCE change 123172 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jul 2007 12:22:30 -0000

On Tuesday 10 July 2007 01:21:23 pm M. Warner Losh wrote:
> In message: <200707090405.l69456Mw026331@repoman.freebsd.org>
>             "Constantine A. Murenin" <cnst@freebsd.org> writes:
> : http://perforce.freebsd.org/chv.cgi?CH=123172
> : 
> : Change 123172 by cnst@dale on 2007/07/09 04:04:33
> : 
> : 	print nameunit before chip name, which wasn't printed 
> : 	because on OpenBSD lm produced only one line in dmesg
> : 	
> : 	On OpenBSD:
> : 		lm0 at isa0 port 0x290/8: W83627DHG
> : 	
> : 	Now on FreeBSD:
> : 		lm0 at port 0x290 on isa0
> : 		lm0: W83627DHG
> 
> You should be setting the device description to W83627DHG if at all
> possible.  That will result in:
> 
> lm0: <W83627DHG> at port 0x290 on isa0

Also, in general you should use device_printf().  That is use:

	device_printf(dev, "%s\n", my_string);

rather than:

	printf("%s: ", device_get_nameunit(dev));
	...
	printf("%s\n", my_string);

This does look like you need to use device_set_desc() in your probe routine 
though.

-- 
John Baldwin