From owner-svn-src-user@FreeBSD.ORG Thu Nov 28 13:15:05 2013 Return-Path: Delivered-To: svn-src-user@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4F8DBE01; Thu, 28 Nov 2013 13:15:05 +0000 (UTC) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 400F31D63; Thu, 28 Nov 2013 13:15:03 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id PAA24292; Thu, 28 Nov 2013 15:15:02 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Vm1Qr-0009wQ-NK; Thu, 28 Nov 2013 15:15:01 +0200 Message-ID: <529741CE.7040805@FreeBSD.org> Date: Thu, 28 Nov 2013 15:14:54 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Aleksandr Rybalko , src-committers@FreeBSD.org, svn-src-user@FreeBSD.org Subject: Re: svn commit: r257451 - in user/ed/newcons/sys/dev/drm2: . i915 radeon References: <201310311439.r9VEd5fh025537@svn.freebsd.org> In-Reply-To: <201310311439.r9VEd5fh025537@svn.freebsd.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Nov 2013 13:15:05 -0000 on 31/10/2013 16:39 Aleksandr Rybalko said the following: > Author: ray > Date: Thu Oct 31 14:39:04 2013 > New Revision: 257451 > URL: http://svnweb.freebsd.org/changeset/base/257451 > > Log: > Change drm2 to attach fbd as device. > Radeon driver not ready yet. > > Sponsored by: The FreeBSD Foundation > > Modified: > user/ed/newcons/sys/dev/drm2/drm_fb_helper.c > user/ed/newcons/sys/dev/drm2/i915/i915_drv.c > user/ed/newcons/sys/dev/drm2/radeon/radeon_drv.c > > Modified: user/ed/newcons/sys/dev/drm2/i915/i915_drv.c > ============================================================================== > --- user/ed/newcons/sys/dev/drm2/i915/i915_drv.c Thu Oct 31 14:11:14 2013 (r257450) > +++ user/ed/newcons/sys/dev/drm2/i915/i915_drv.c Thu Oct 31 14:39:04 2013 (r257451) > @@ -400,6 +421,10 @@ static device_method_t i915_methods[] = > DEVMETHOD(device_suspend, i915_suspend), > DEVMETHOD(device_resume, i915_resume), > DEVMETHOD(device_detach, drm_detach), > + > + /* Framebuffer service methods */ > + DEVMETHOD(fb_getinfo, i915_fb_helper_getinfo), > + > DEVMETHOD_END > }; > > > Modified: user/ed/newcons/sys/dev/drm2/radeon/radeon_drv.c > ============================================================================== > --- user/ed/newcons/sys/dev/drm2/radeon/radeon_drv.c Thu Oct 31 14:11:14 2013 (r257450) > +++ user/ed/newcons/sys/dev/drm2/radeon/radeon_drv.c Thu Oct 31 14:39:04 2013 (r257451) > @@ -495,6 +518,10 @@ static device_method_t radeon_methods[] > DEVMETHOD(device_suspend, radeon_suspend), > DEVMETHOD(device_resume, radeon_resume), > DEVMETHOD(device_detach, drm_detach), > + > + /* Framebuffer service methods */ > + DEVMETHOD(fb_getinfo, radeon_fb_helper_getinfo), > + > DEVMETHOD_END > }; It seems that this change these modules can not be loaded when a kernel is compiled with syscons rather than vt (newcons). The problem is that fb_getinfo_desc is undefined in that case. It is supposed to come from fb_if.m -> fb_if.c -> fb_if.o. Is this intentional? -- Andriy Gapon