From owner-svn-src-all@FreeBSD.ORG Mon Dec 22 04:14:43 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 68C6E1065676; Mon, 22 Dec 2008 04:14:43 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 389DA8FC1A; Mon, 22 Dec 2008 04:14:42 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id mBM4Egqr054668 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 21 Dec 2008 20:14:42 -0800 (PST) (envelope-from sam@freebsd.org) Message-ID: <494F1432.1000007@freebsd.org> Date: Sun, 21 Dec 2008 20:14:42 -0800 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.9 (X11/20071125) MIME-Version: 1.0 To: VANHULLEBUS Yvan References: <200812211916.mBLJGUGL040167@svn.freebsd.org> <494E9F83.5030109@freebsd.org> <20081221222209.GA3507@zeninc.net> In-Reply-To: <20081221222209.GA3507@zeninc.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC-sonic.net-Metrics: ebb.errno.com; whitelist Cc: svn-src-releng@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186377 - in releng/7.1/sys: . contrib/pf dev/cxgb net X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Dec 2008 04:14:43 -0000 VANHULLEBUS Yvan wrote: > On Sun, Dec 21, 2008 at 11:56:51AM -0800, Sam Leffler wrote: > >> VANHULLEBUS Yvan wrote: >> >>> Author: vanhu >>> Date: Sun Dec 21 19:16:30 2008 >>> New Revision: 186377 >>> URL: http://svn.freebsd.org/changeset/base/186377 >>> >>> Log: >>> Fix to bug kern/126850. Only dispatch event hander if the interface had a parent... >>> PR: kern/126850 >>> Reviewed by: EvilSam >>> Approved by: re >>> >>> >>> >> There were reports that this caused a panic on HEAD under certain >> conditions. That is why it was NOT MFC'd to RELENG_7. >> > > Do you have more details about those panics ? > Does the panic happens after the ifconfig vlan0 create && ifconfig > vlan0 -vlandev, or in another situation ? > > > And I may ask a stupid question, but shoudn't such information be > added to the PR, so it would be easy to know/remind it ? > I reviewed mail and it appears I mis-remembered things. It looks like Jack MFC'd the vlan event stuff from HEAD to RELENG_7 (thought I'd caught him before he actually committed the changes) and so users experienced panic's. I remember the mail (found it on net@) but didn't recall the panic had been hit on RELENG_7; thought it was on HEAD. So it appears the MFC you did was correct; it should fix the problem. Sam