Date: Sun, 21 Dec 2008 20:14:42 -0800 From: Sam Leffler <sam@freebsd.org> To: VANHULLEBUS Yvan <vanhu@freebsd.org> Cc: svn-src-releng@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186377 - in releng/7.1/sys: . contrib/pf dev/cxgb net Message-ID: <494F1432.1000007@freebsd.org> In-Reply-To: <20081221222209.GA3507@zeninc.net> References: <200812211916.mBLJGUGL040167@svn.freebsd.org> <494E9F83.5030109@freebsd.org> <20081221222209.GA3507@zeninc.net>
next in thread | previous in thread | raw e-mail | index | archive | help
VANHULLEBUS Yvan wrote: > On Sun, Dec 21, 2008 at 11:56:51AM -0800, Sam Leffler wrote: > >> VANHULLEBUS Yvan wrote: >> >>> Author: vanhu >>> Date: Sun Dec 21 19:16:30 2008 >>> New Revision: 186377 >>> URL: http://svn.freebsd.org/changeset/base/186377 >>> >>> Log: >>> Fix to bug kern/126850. Only dispatch event hander if the interface had a parent... >>> PR: kern/126850 >>> Reviewed by: EvilSam >>> Approved by: re >>> >>> >>> >> There were reports that this caused a panic on HEAD under certain >> conditions. That is why it was NOT MFC'd to RELENG_7. >> > > Do you have more details about those panics ? > Does the panic happens after the ifconfig vlan0 create && ifconfig > vlan0 -vlandev, or in another situation ? > > > And I may ask a stupid question, but shoudn't such information be > added to the PR, so it would be easy to know/remind it ? > I reviewed mail and it appears I mis-remembered things. It looks like Jack MFC'd the vlan event stuff from HEAD to RELENG_7 (thought I'd caught him before he actually committed the changes) and so users experienced panic's. I remember the mail (found it on net@) but didn't recall the panic had been hit on RELENG_7; thought it was on HEAD. So it appears the MFC you did was correct; it should fix the problem. Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?494F1432.1000007>