Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 24 Jul 2009 00:11:26 +0400
From:      Anonymous <swell.k@gmail.com>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/137043: [patch] multimedia/mplayer: add SSSE3 support
Message-ID:  <86bpnbgnwx.fsf@gmail.com>
Resent-Message-ID: <200907232020.n6NKK1wq056152@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         137043
>Category:       ports
>Synopsis:       [patch] multimedia/mplayer: add SSSE3 support
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 23 20:20:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Anonymous
>Release:        FreeBSD 8.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD luffy 8.0-BETA2 FreeBSD 8.0-BETA2 #0 r195826M: Wed Jul 22 20:12:21 UTC 2009     root@luffy:/usr/obj/usr/src/sys/PHOENIX  amd64

$ make showconfig
===> The following configuration options are available for mplayer-0.99.11_15:
     DEBUG=      off "Include debug symbols in mplayer's binary files"
     RTCPU=      on  "Let mplayer dynamically check for CPU features"
     OCFLAGS=    on  "Use optimized compiler flags"
     SIMD=       on  "Allow mplayer to use vector engines (MMX...)"
     IPV6=       off "Include inet6 network support"
     X11=        on  "Enable X11 support for mplayer's video output"
     X11XV=      on  "X11 video drivers: XV"
     X11DGA=     off "X11 video drivers: DGA"
     X11GL=      off "X11 video drivers: OpenGL"
     X11XIN=     off "X11 video drivers: Xinerama"
     X11VM=      off "X11 VidMode support"
     X11XVMC=    off "Enable XvMC acceleration"
     GUI=        off "Enable GTK2 graphical user interface with X11"
     SDL=        off "Enable SDL video output"
     VIDIX=      off "Enable VIDIX video output on supported archs"
     SKINS=      off "Force dependency on mplayer-skins"
     FREETYPE=   on  "Use freetype for OSD fonts (TrueType!)"
     RTC=        off "Add support for kernel real time clock timing"
     ARTS=       off "Enable KDE sound system support"
     ESOUND=     off "Enable GNOME esound support"
     JACK=       off "Enable JackIt audio server support"
     NAS=        off "Enable NAS sound server support"
     OPENAL=     off "Enable OpenAL sound support"
     LIBUNGIF=   on  "Enable gif support"
     AALIB=      off "Enable aalib support"
     LIBCACA=    off "Enable libcaca support"
     SVGALIB=    off "Enable svgalib support"
     LIBDV=      off "Enable libdv support"
     MAD=        off "Enable mad MPEG audio engine support"
     DTS=        off "Enable DTS audio codec support"
     LIBMPCDEC=  off "Enable libmpcdec support"
     LADSPA=     off "Enable LADSPA plugin support"
     SPEEX=      off "Enable speex audio codec support"
     TREMOR=     off "Use built-in tremor instead of libvorbis"
     XMMS=       off "Enable XMMS plugin support"
     THEORA=     on  "Enable ogg theora video support"
     WIN32=      off "Enable win32 codec set on the IA32 arch"
     AMR=        off "Enable AMR audio codec support"
     X264=       off "Enable x264 (H.264) video codec support"
     XANIM=      off "Enable xanim DLL support"
     XVID=       off "Enable XVID video codec support"
     REALPLAYER= off "Enable real player plugin"
     LIVEMEDIA=  off "Enable LIVE555 streaming support"
     SMB=        off "Enable Samba input support"
     FRIBIDI=    off "Enable FriBiDi support"
     LIRC=       off "Enable lirc support"
     LIBCDIO=    off "Enable libcdio support"
     CDPARANOIA= off "Enable cdparanoia support"
     LIBLZO=     off "Enable external liblzo library"
     JOYSTICK=   off "Enable joystick support"
===> Use 'make config' to modify these settings

Tested with/without RTCPU option.
>Description:
- put --disable-ssse3 under WITHOUT_SSSE3 knob
- depend WITH_SSSE3 on compiler/assembler from ports
- we don't need -DBROKEN_RELOCATIONS hack when using compiler/assembler
  from ports
>How-To-Repeat:
>Fix:
--- mplayer.diff begins here ---
Index: multimedia/mplayer/Makefile
===================================================================
RCS file: /home/csup/ports/multimedia/mplayer/Makefile,v
retrieving revision 1.187
diff -u -p -r1.187 Makefile
--- multimedia/mplayer/Makefile	17 Jul 2009 18:34:49 -0000	1.187
+++ multimedia/mplayer/Makefile	23 Jul 2009 18:46:41 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	mplayer
 PORTVERSION=	${MPLAYER_PORT_VERSION}
-PORTREVISION=	14
+PORTREVISION=	15
 
 COMMENT=	High performance media player supporting many formats
 
@@ -76,8 +76,7 @@ CONFFILES=	example.conf input.conf menu.
 
 .include <bsd.port.pre.mk>
 
-CONFIGURE_ARGS+=	--disable-ssse3 \
-			--disable-directfb \
+CONFIGURE_ARGS+=	--disable-directfb \
 			--disable-faac \
 			--disable-twolame \
 			--disable-mencoder
Index: multimedia/mplayer/Makefile.options
===================================================================
RCS file: /home/csup/ports/multimedia/mplayer/Makefile.options,v
retrieving revision 1.7
diff -u -p -r1.7 Makefile.options
--- multimedia/mplayer/Makefile.options	31 Mar 2009 13:58:17 -0000	1.7
+++ multimedia/mplayer/Makefile.options	23 Jul 2009 19:59:16 -0000
@@ -32,6 +32,11 @@
 # kernel config. This is standard for 5.x and newer systems on I686_CPU
 # and later. 4.x users will have to define this explicitly.
 #
+# WITHOUT_SSSE3
+# default: autodetected
+# disables using of ssse3 code
+# NOTE: SSSE3 support is available for gcc >= 4.3.0, binutils >= 2.18.
+#
 # Feature options:
 # These options influence some general behaviour of mplayer. Most of the featues,
 # for example all the codecs, are selected via the OPTIONS framework.
@@ -258,6 +263,9 @@ CONFIGURE_ARGS+=--disable-3dnow --disabl
 .if defined(WITHOUT_SSE) || defined(WITHOUT_SIMD)
 CONFIGURE_ARGS+=--disable-mmxext --disable-sse --disable-sse2
 .endif
+.if defined(WITHOUT_SSSE3) || defined(WITHOUT_SIMD)
+CONFIGURE_ARGS+=--disable-ssse3
+.endif # WITHOUT_SSSE3
 .endif #WITH_RTCPU
 .if !defined(WITHOUT_WIN32) && !defined(PACKAGE_BUILDING) && ${ARCH} == "i386"
 RUN_DEPENDS+=	${CODEC_DETECTION_FILE}:${CODEC_PORT}
@@ -268,6 +276,15 @@ CODEC_DETECTION_FILE!=	${MAKE} -f ${CODE
 CONFIGURE_ARGS+=	--disable-win32dll \
 			--disable-qtx
 .endif
+.if !defined(WITHOUT_SSSE3)
+USE_GCC=	4.3+
+AS=		${LOCALBASE}/bin/as
+BUILD_DEPENDS+=	${AS}:${PORTSDIR}/devel/binutils
+.else # WITH_SSSE3
+.if ${ARCH} == "amd64"
+CFLAGS+= 	-DBROKEN_RELOCATIONS
+.endif # ARCH == amd64
+.endif # WITH_SSSE3
 .endif # ARCH == i386/amd64
 
 .if defined(WITH_REALPLAYER)
Index: multimedia/mplayer/files/patch-libavcodec-Makefile
===================================================================
RCS file: multimedia/mplayer/files/patch-libavcodec-Makefile
diff -N multimedia/mplayer/files/patch-libavcodec-Makefile
--- multimedia/mplayer/files/patch-libavcodec-Makefile	12 Dec 2007 23:26:36 -0000	1.1
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,13 +0,0 @@
---- libavcodec/Makefile.orig	2007-10-07 15:49:37.000000000 -0400
-+++ libavcodec/Makefile	2007-11-14 02:49:09.000000000 -0500
-@@ -6,6 +6,10 @@
- 
- CFLAGS += -I$(SRC_PATH)/libswscale -I$(SRC_PATH)/libavcodec
- 
-+ifeq ($(ARCH_X86_64),yes)
-+CFLAGS += -DBROKEN_RELOCATIONS
-+endif
-+
- OBJS = allcodecs.o \
-        audioconvert.o \
-        bitstream.o \
Index: multimedia/mencoder/Makefile
===================================================================
RCS file: /home/csup/ports/multimedia/mencoder/Makefile,v
retrieving revision 1.9
diff -u -p -r1.9 Makefile
--- multimedia/mencoder/Makefile	6 Jul 2009 21:25:55 -0000	1.9
+++ multimedia/mencoder/Makefile	23 Jul 2009 19:12:55 -0000
@@ -78,8 +78,7 @@ CONFIGURE_ARGS+=	--disable-vidix-interna
 			--disable-svga \
 			--disable-aa \
 			--disable-joystick \
-			--disable-directfb \
-			--disable-ssse3
+			--disable-directfb
 
 .include "${.CURDIR}/../mplayer/Makefile.options"
 
--- mplayer.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86bpnbgnwx.fsf>