From owner-freebsd-bugs  Tue Jun 17 15:30:05 1997
Return-Path: <owner-bugs>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id PAA12480
          for bugs-outgoing; Tue, 17 Jun 1997 15:30:05 -0700 (PDT)
Received: (from gnats@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id PAA12465;
          Tue, 17 Jun 1997 15:30:02 -0700 (PDT)
Resent-Date: Tue, 17 Jun 1997 15:30:02 -0700 (PDT)
Resent-Message-Id: <199706172230.PAA12465@hub.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@FreeBSD.ORG, sclawson@marker.cs.utah.edu
Received: from marker.cs.utah.edu (marker.cs.utah.edu [155.99.212.61])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id PAA12242
          for <FreeBSD-gnats-submit@freebsd.org>; Tue, 17 Jun 1997 15:27:08 -0700 (PDT)
Received: (from sclawson@localhost) by marker.cs.utah.edu (8.8.5/8.7.3) id QAA29888; Tue, 17 Jun 1997 16:27:07 -0600 (MDT)
Message-Id: <199706172227.QAA29888@marker.cs.utah.edu>
Date: Tue, 17 Jun 1997 16:27:07 -0600 (MDT)
From: stephen clawson <sclawson@marker.cs.utah.edu>
Reply-To: sclawson@marker.cs.utah.edu
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: gnu/3894: manpath segfaults if it dosen't understand a line in manpath.config.
Sender: owner-bugs@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         3894
>Category:       gnu
>Synopsis:       manpath segfaults if it dosen't understand a line in manpath.config.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 17 15:30:00 PDT 1997
>Last-Modified:
>Originator:     stephen clawson
>Organization:
// stephen clawson				sclawson@cs.utah.edu
// university of utah			        
>Release:        FreeBSD 2.1.7-RELEASE i386
>Environment:

	

	Standard FreeBSD 2.1.7-RELEASE manpath binary on a ppro 200.

>Description:

	

	manpath segfaults if it dosen't understand a line in
manpath.config because it's calling gripe_reading_mp_config without 
an argument.

>How-To-Repeat:

	Put anything nonstandard in /etc/manpath.config (ie. add 
a `foo' at the end), or misspell one of the keywords like I did. =)

>Fix:
	
	

	Either hardcode the config file name in 
gripe_reading_mp_config, or add the required argument.  This seems to
affect all versions of FreeBSD and should probably be fixed in _both_
copies of manpath.c (/usr/src/gnu/usr.bin/man/{manpath,man}/manpath.c).


diff -u -r1.2 manpath.c
--- manpath.c   1995/05/30 05:02:05     1.2
+++ manpath.c   1997/06/17 21:24:47
@@ -135,7 +135,7 @@
   char *get_manpath ();

   if (get_dirlist ())
-      gripe_reading_mp_config ();
+      gripe_reading_mp_config (config_file);

   if ((manpathlist = getenv ("MANPATH")) != NULL)
     /*
@@ -254,7 +254,7 @@
        }
       else
        {
-         gripe_reading_mp_config ();
+         gripe_reading_mp_config (config_file);
        }
       dlp++;
     }
>Audit-Trail:
>Unformatted: