Date: Sun, 30 Dec 2018 14:21:05 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 233980] lang/smlnj: Fails to build (-m32) on poudriere on stable/12 (amd64) Message-ID: <bug-233980-7788-158gZNZcAD@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-233980-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-233980-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233980 --- Comment #7 from Johannes 5 <joemann@beefree.free.de> --- On Sun, 30 Dec 2018 08:14:25 +0000, Kubilay Kocak <koobs@FreeBSD.org> wrote: > Thanks for the patch Johannes. > Can you confirm that the changes pass QA (portlint, poudriere at > least). No, the patch above (smlnj.patch.20181220) does not. But after some wrestling with poudriere's stage-qa I'm confident that this improved version of the patch will make us happy:) <ftp://offshore.free.de/pub/patch/smlnj.patch.20181230>; MD5 (smlnj.patch.20181220) =3D 98d2cf0c2436f3c4ce11dcc9db3d0cdd There's still one portlint warning concerning the ${CHOWN} in the Makefile (which was introduced to avoid a stage-qa warning;). But I don't think that resolving this warning by further obfuscating the PLIST generation in the Makefile with even more invocations of sed would be beneficial. Please correct me if I get the priorities wrong here. > It would also be preferable to separate the patches for fixing this > issue alone, and the version update I thought about that as well, but doing the QA is very tedious over here (esp. for my prehistoric i386 equipment;). So I decided to rather put my rare efforts into the version update (the first one after 4 years of 110.77:-(. It's not difficult to split out the ASFLAGS parts of the patch, but I can't see sufficient reason for this because the update patch includes them. So I suggest that I'll finish testing smlnj.patch.20181230 today, make the resulting poudriere testport outputs available, and submit it in a seperate PR like "lang/smlnj: update to 110.84, unbreak on 12/amd64". If you (dis)agree and/or find the time to check smlnj.patch.20181230 on your fast machines, please let me know. ("Fast" is useful when testing the port's RECOMPILE option - which also works on amd64 now!-) Thanks! Johannes --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-233980-7788-158gZNZcAD>