From owner-freebsd-net@FreeBSD.ORG Fri Mar 21 02:51:45 2014 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DF290633 for ; Fri, 21 Mar 2014 02:51:45 +0000 (UTC) Received: from mail-qc0-x22e.google.com (mail-qc0-x22e.google.com [IPv6:2607:f8b0:400d:c01::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9EF83A7E for ; Fri, 21 Mar 2014 02:51:45 +0000 (UTC) Received: by mail-qc0-f174.google.com with SMTP id c9so2095735qcz.5 for ; Thu, 20 Mar 2014 19:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Ic5L5mtGf60+Mj7iT9+ey3Kzpy2xRvN9lEJ/Kja36VY=; b=D+gLz44tgynU9zKgrRpxO9l/77+7ytQv2nbh0oDjppWjpV/F61qJ82L/OEqKHwSoa1 O7ONq0BRkCngkrB0wuNmYEABFgt3aPQ5RtLuo7i3tl1ZfFjp4TmAknv40qsdOyIaYS5Q MKFteVyRTSuz+m51Pzc9d2jZAY4DjqhuCIhRpEwQ7YSdhnwcgbsvvkCh7oFYTxUIpsMB 2BRWKy7tgUcP5nuhBNr3ECqsG1JkzxcBHPvpe2TocLSUsCLcI8X7GXkmu31heO1inDzb wLp+Fi4NZ7l0DP0pgB6exI8K/Luvxv/JlJA+CPfwJjkcrpPCEFQmw0jkR12xHq5VmxPp voWQ== MIME-Version: 1.0 X-Received: by 10.140.100.129 with SMTP id s1mr52028504qge.43.1395370304863; Thu, 20 Mar 2014 19:51:44 -0700 (PDT) Received: by 10.96.79.97 with HTTP; Thu, 20 Mar 2014 19:51:44 -0700 (PDT) In-Reply-To: <729766714.648507.1395370078262.JavaMail.root@uoguelph.ca> References: <729766714.648507.1395370078262.JavaMail.root@uoguelph.ca> Date: Thu, 20 Mar 2014 23:51:44 -0300 Message-ID: Subject: Re: 9.2 ixgbe tx queue hang From: Christopher Forgeron To: Rick Macklem Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: FreeBSD Net X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Mar 2014 02:51:45 -0000 Sorry Rick, what's the small change you wanted in sys/netinet/tcp_output.c at 777-778? I see it's calc'ing length... or did you want me to take the whole file back to 9.1-RELEASE ? On Thu, Mar 20, 2014 at 11:47 PM, Rick Macklem wrote: > Christopher Forgeron wrote: > > Yes, there is something broken in TSO for sure, as disabling it > > allows me > > to run without error. It is possible that the drop in performance is > > allowing me to stay under a critical threshold for the problem, but > > I'd > > feel happier testing to make sure. > > > > I understand what you're asking for in the patch, I'll make the edits > > tomorrow and recompile a test kernel and see. > > > I also suggested a small change (basically reverting it to the 9.1 code) > for tcp_output() in sys/netinet/tcp_output.c (around line# 777-778). > You might as well throw that in at the same time. > > Thanks for all your work with this (and this applies to others that > have been working on this as well.) > > rick > > > Right now I'm running tests on the ixgbe that Jack sent. Even if his > > patch > > fixes the issue, I wonder if something else isn't broken in TSO, as > > the > > ixgbe code has had these lines for a long time, and it's only on this > > 10.0 > > build that I have issues. > > > > I'll be following up tomorrow with info on either outcome. > > > > Thanks for your help.. your rusty networking is still better than > > mine. :-) > > > > > > On Thu, Mar 20, 2014 at 11:13 PM, Rick Macklem > > wrote: > > > > > Christopher Forgeron wrote: > > > > > > > > Output from the patch you gave me (I have screens of it.. let me > > > > know > > > > what you're hoping to see. > > > > > > > > > > > > Mar 20 16:37:22 SAN0 kernel: after mbcnt=33 pklen=65538 > > > > actl=65538 > > > > Mar 20 16:37:22 SAN0 kernel: before pklen=65538 actl=65538 > > > Hmm. I think this means that the loop that generates TSO segments > > > in > > > tcp_output() is broken, since I'm pretty sure that the maximum size > > > should be is IP_MAXPACKET (65535). > > > > > > Either that or some non-TCP socket is trying to send a packet that > > > exceeds IP_MAXPACKET for some reason. > > > > > > Would it be possible to add a printf() for m->m_pkthdr.csum_flags > > > to the before case, in the "if" that generates the before printf? > > > I didn't think to put this in, but CSUM_TSO will be set if it > > > is a TSO segment, I think? My networking is very rusty. > > > (If how to add this isn't obvious, just email and I'll update > > > the patch.) > > > > > > Thanks for doing this, rick > > > > > > > > _______________________________________________ > > freebsd-net@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-net > > To unsubscribe, send any mail to > > "freebsd-net-unsubscribe@freebsd.org" > > >