From owner-svn-src-head@freebsd.org Sat Feb 29 19:17:25 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DA71E265FFD; Sat, 29 Feb 2020 19:17:25 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48VGPd4h5cz3J9B; Sat, 29 Feb 2020 19:17:25 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 47FC71F673; Sat, 29 Feb 2020 19:17:25 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 01TJHPf8068198; Sat, 29 Feb 2020 19:17:25 GMT (envelope-from csjp@FreeBSD.org) Received: (from csjp@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 01TJHPoO068197; Sat, 29 Feb 2020 19:17:25 GMT (envelope-from csjp@FreeBSD.org) Message-Id: <202002291917.01TJHPoO068197@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: csjp set sender to csjp@FreeBSD.org using -f From: "Christian S.J. Peron" Date: Sat, 29 Feb 2020 19:17:25 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r358471 - head/sys/security/audit X-SVN-Group: head X-SVN-Commit-Author: csjp X-SVN-Commit-Paths: head/sys/security/audit X-SVN-Commit-Revision: 358471 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Feb 2020 19:17:25 -0000 Author: csjp Date: Sat Feb 29 19:17:24 2020 New Revision: 358471 URL: https://svnweb.freebsd.org/changeset/base/358471 Log: Currently kernel audit events for jail_set(2), jail_get(2), jail_attach(2), jail_remove(2) and finally setloginclass(2) are not being converted and committed into userspace. Add the cases for these syscalls and make sure they are being converted properly. Reviewed by: bz, kevans MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D23882 Modified: head/sys/security/audit/audit_bsm.c Modified: head/sys/security/audit/audit_bsm.c ============================================================================== --- head/sys/security/audit/audit_bsm.c Sat Feb 29 18:41:48 2020 (r358470) +++ head/sys/security/audit/audit_bsm.c Sat Feb 29 19:17:24 2020 (r358471) @@ -809,6 +809,19 @@ kaudit_to_bsm(struct kaudit_record *kar, struct au_rec case AUE_FUTIMESAT: case AUE_GETATTRLIST: case AUE_JAIL: + break; + + /* + * NB: We may want to verify that the appropriate + * audit args are being processed here, but I think + * a bit analysis is required. + */ + case AUE_JAIL_GET: + case AUE_JAIL_SET: + case AUE_JAIL_ATTACH: + case AUE_JAIL_REMOVE: + break; + case AUE_LUTIMES: case AUE_NFS_GETFH: case AUE_LGETFH: @@ -1472,6 +1485,9 @@ kaudit_to_bsm(struct kaudit_record *kar, struct au_rec tok = au_to_text(ar->ar_arg_login); kau_write(rec, tok); } + break; + + case AUE_SETLOGINCLASS: break; case AUE_SETPRIORITY: