From owner-svn-src-head@FreeBSD.ORG Mon Mar 8 15:34:25 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 95AF2106566B; Mon, 8 Mar 2010 15:34:25 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 6713C8FC12; Mon, 8 Mar 2010 15:34:25 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 194BE46B51; Mon, 8 Mar 2010 10:34:25 -0500 (EST) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 6271B8A025; Mon, 8 Mar 2010 10:34:24 -0500 (EST) From: John Baldwin To: Warner Losh Date: Mon, 8 Mar 2010 09:21:34 -0500 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) References: <201003072237.o27MbZnh088286@svn.freebsd.org> In-Reply-To: <201003072237.o27MbZnh088286@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201003080921.34274.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 08 Mar 2010 10:34:24 -0500 (EST) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.5 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r204850 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Mar 2010 15:34:25 -0000 On Sunday 07 March 2010 5:37:35 pm Warner Losh wrote: > Author: imp > Date: Sun Mar 7 22:37:35 2010 > New Revision: 204850 > URL: http://svn.freebsd.org/changeset/base/204850 > > Log: > Bump up the firmware_table from 30 to 50. bwn needs more than 30, it > seems. Are you sure? The error report I saw was from having firmwares for both bwi(4) and bwn(4) loaded. Both of them use a lot of firmware images, but I don't think either one in isolation uses more than 30. I really think that FIRMWARE_MAX should at the least become a loader tunable and have the array malloc'd either on-demand or via a SYSINIT(). -- John Baldwin