Date: Thu, 20 Jul 2000 15:01:05 +0100 From: Brian Somers <brian@Awfulhak.org> To: Sheldon Hearn <sheldonh@uunet.co.za> Cc: Brian Somers <brian@Awfulhak.org>, Jordan Hubbard <jkh@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Brian Somers <brian@FreeBSD.org>, shin@FreeBSD.org, brian@Awfulhak.org Subject: Re: cvs commit: src/lib/libc/net rcmd.3 rcmd.c Message-ID: <200007201401.PAA02340@hak.lan.Awfulhak.org> In-Reply-To: Message from Sheldon Hearn <sheldonh@uunet.co.za> of "Thu, 20 Jul 2000 15:22:29 %2B0200." <3819.964099349@axl.ops.uunet.co.za>
next in thread | previous in thread | raw e-mail | index | archive | help
>
>
> On Thu, 20 Jul 2000 14:17:13 +0100, Brian Somers wrote:
>
> > I don't think a version bump is required as the function & args
> > remain the same. The API change is that the *ahost value should now
> > be free()d by the application whereas before it was already freed by
> > rcmd() :-)
>
> Doesn't that mean that long-running applications that make use of this
> interface will develop memory leaks unless they're changed? Are you
> saying that the bump isn't required because new applications don't need
> to know and old applications won't check?
Yes, all existing applications will now have a memory leak. This is
bad, but not as bad as the alternatives (see my other post cc'd to
cvs-committers).
Thinking about it, you could argue that a version bump is necessary
so that new applications that know about needing to free(*ahost) will
be linked against the library with the higher version number and will
never end up freeing *ahost when it's been returned by an old library
that had already free()d it.
The alternative would be to bump __FreeBSD_version for this purpose.
Whaddaya think ?
> Just want to make sure I understand for the right reasons. ;-)
>
> Ciao,
> Sheldon.
--
Brian <brian@Awfulhak.org> <brian@[uk.]FreeBSD.org>
<http://www.Awfulhak.org>; <brian@[uk.]OpenBSD.org>
Don't _EVER_ lose your sense of humour !
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200007201401.PAA02340>