From owner-dev-commits-src-main@freebsd.org Fri Mar 5 19:40:31 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 60A05564F19; Fri, 5 Mar 2021 19:40:31 +0000 (UTC) (envelope-from freqlabs@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DsdPW2MpTz3N7r; Fri, 5 Mar 2021 19:40:31 +0000 (UTC) (envelope-from freqlabs@FreeBSD.org) Received: from Ryans-MacBook-Pro.local (69-228-200-148.lightspeed.knvltn.sbcglobal.net [69.228.200.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: freqlabs/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 124E7ACEF; Fri, 5 Mar 2021 19:40:31 +0000 (UTC) (envelope-from freqlabs@FreeBSD.org) Subject: Re: git: c4ba4aa54718 - main - libifconfig: Overhaul ifconfig_media_* interfaces To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202103051123.125BNubR059014@gitrepo.freebsd.org> From: Ryan Moeller Message-ID: <20c6efb4-8b57-ae78-3808-b49b07ac284d@FreeBSD.org> Date: Fri, 5 Mar 2021 14:40:29 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 19:40:31 -0000 On 3/5/21 1:19 PM, Konstantin Belousov wrote: > On Fri, Mar 05, 2021 at 11:23:56AM +0000, Ryan Moeller wrote: >> The branch main has been updated by freqlabs: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=c4ba4aa547184ab401204096cdad9def4ab37964 >> >> commit c4ba4aa547184ab401204096cdad9def4ab37964 >> Author: Ryan Moeller >> AuthorDate: 2021-03-02 10:29:17 +0000 >> Commit: Ryan Moeller >> CommitDate: 2021-03-05 09:15:55 +0000 >> >> libifconfig: Overhaul ifconfig_media_* interfaces >> >> Define an ifmedia_t type to use for ifmedia words. >> >> Add ifconfig_media_lookup_* functions to lookup ifmedia words by name. >> >> Get media options as an array of option names rather than formatting it >> as a comma-delimited list into a buffer. >> >> Sprinkle const on static the static description tables for peace of >> mind. >> >> Don't need to zero memory allocated by calloc. >> >> Reviewed by: kp >> MFC after: 2 weeks >> Differential Revision: https://reviews.freebsd.org/D29029 >> --- >> lib/libifconfig/Makefile | 2 +- >> lib/libifconfig/Symbol.map | 9 +- >> lib/libifconfig/libifconfig.h | 69 +++++++- >> lib/libifconfig/libifconfig_media.c | 339 ++++++++++++++++++++++++------------ >> share/examples/libifconfig/status.c | 27 ++- >> 5 files changed, 324 insertions(+), 122 deletions(-) >> >> diff --git a/lib/libifconfig/Makefile b/lib/libifconfig/Makefile >> index 73dad36c1dc5..c6f006018427 100644 >> --- a/lib/libifconfig/Makefile >> +++ b/lib/libifconfig/Makefile >> @@ -7,7 +7,7 @@ INTERNALLIB= true >> LIBADD= m >> >> SHLIBDIR?= /lib >> -SHLIB_MAJOR= 1 >> +SHLIB_MAJOR= 2 >> >> VERSION_DEF= ${LIBCSRCDIR}/Versions.def >> SYMBOL_MAPS= ${.CURDIR}/Symbol.map > libifconfig is marked as internal, but we provide symbol versioning for it, > and do it in the normal FreeBSD namespace. On one hand, our policy is to > not bump symvered libs and to provide binary compat shims as needed, on the > other, this is internal lib. > > What is the purpose of maintaining symbol versions for it? I have work in progress that changes libifconfig to a private lib. I'm not sure why markj@ added the symbol map, but I've been forced to maintain it for my later changes to work. -Ryan