From owner-svn-src-all@freebsd.org Tue Jun 4 19:22:29 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8DD7915BB85A; Tue, 4 Jun 2019 19:22:29 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7096E8267E; Tue, 4 Jun 2019 19:22:28 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x430.google.com with SMTP id u17so13274217pfn.7; Tue, 04 Jun 2019 12:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=NXwCn4jHt6aYwNeb0S1mm6odVOB/q9vJf605qno4FrE=; b=NWKNCi9TQnUokhA40F6sEiFDxi+lChSz8Gp+73vTe3wmSSBAz31xDoBKj+I0POEWKY knOPS+Gx0RMks0zAxM3g/yIKKZUJySuA1IspvjmCMCobf1tTKJQAZd9zkOakP8S0DSls GDO9sO4x8zNwFkbjlv5lw2/7qVmi0SDfBLvQ1qPW53ig1kMANh7lvcTPq6C3q6HygIqT smH04u1mmLfuXZCLm6GWZw6lLAr2sUqOz0cuAweSyaqf6/pe8NCY+QGn1czbSXcuc2RU 5NKBm5N1362QrXDn6Qv8cV22Q24APCFDkFKGGHfZN4ZkRTQLZiCMqllzGzCqHv+kTNSa bm8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=NXwCn4jHt6aYwNeb0S1mm6odVOB/q9vJf605qno4FrE=; b=DnyahYzmDq5PVDy+N77DO5q/qkdscn/VggfpArb4g6vwh+INM97yt0ZJ4bSaqoXK64 uU61dKv19sALwTAa4LlpWTIMXtLKQNwG0Tco0dfuTYnD855+CHglbiRnsm9b9xDfwQgN zD9JKqjOTjGjD/yD3HH5Bz/V0w2ymm26BwG4FTiW6hcfTkFzzSI7csvNUpXYG8Q5sqxU /iPSvtJGet2rdaYvW4/jiJ2GJEyAGx80402nN+rL+vBDaJ7tekNy7zw1DZkL4PxDge+q AEqWImjJZ8adhiIod5lR4f4tQEdhwwkWGDqEU2V/6Z/FXnt/F0l6utH30T4FQBsmdyC9 KiRg== X-Gm-Message-State: APjAAAWYagCiKj6HLHTBQZwu7zg8gnCA7JVwIuz3aA2yGIufD42ctrjp T3Oi4lHKZGZchuoODaaGAdPjH3SwT5s= X-Google-Smtp-Source: APXvYqyDeYseBwA/g3oAAz1OtYGOZ7hykBHvCp8K+fEXbVNsIUvBBVBEzj4XZyv6zgq+O0rY4l+phQ== X-Received: by 2002:a63:1343:: with SMTP id 3mr210616pgt.426.1559676147063; Tue, 04 Jun 2019 12:22:27 -0700 (PDT) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id b17sm2707959pfb.18.2019.06.04.12.22.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2019 12:22:26 -0700 (PDT) From: Enji Cooper Message-Id: <059B57C6-874A-4E27-A7A7-4EEBDE45EA66@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: svn commit: r348540 - head Date: Tue, 4 Jun 2019 12:22:25 -0700 In-Reply-To: <201906031906.x53J6mPi044273@gndrsh.dnsmgr.net> Cc: Maxim Sobolev , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org To: rgrimes@freebsd.org References: <201906031906.x53J6mPi044273@gndrsh.dnsmgr.net> X-Mailer: Apple Mail (2.3445.104.11) X-Rspamd-Queue-Id: 7096E8267E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=NWKNCi9T; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::430 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-6.49 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; IP_SCORE(-3.00)[ip: (-9.40), ipnet: 2607:f8b0::/32(-3.24), asn: 15169(-2.30), country: US(-0.06)]; RCVD_IN_DNSWL_NONE(0.00)[0.3.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jun 2019 19:22:29 -0000 > On Jun 3, 2019, at 12:06 PM, Rodney W. Grimes = wrote: >=20 >> Author: sobomax >> Date: Mon Jun 3 15:34:00 2019 >> New Revision: 348540 >> URL: https://svnweb.freebsd.org/changeset/base/348540 >>=20 >> Log: >> Rollback the rest of the botched r348521. Re-work would be posted to >> reviews. Sorry. >>=20 >> Reported by: Enji Cooper >>=20 >> Modified: >> head/Makefile.inc1 >>=20 >> Modified: head/Makefile.inc1 >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/Makefile.inc1 Mon Jun 3 15:32:42 2019 = (r348539) >> +++ head/Makefile.inc1 Mon Jun 3 15:34:00 2019 = (r348540) >> @@ -887,7 +887,7 @@ MTREEFLAGS+=3D -W >> INSTALLFLAGS+=3D -h sha256 >> .endif >> .if defined(DB_FROM_SRC) || defined(NO_ROOT) >> -IMAKE_INSTALL=3D INSTALL=3D"${INSTALL} ${INSTALLFLAGS}" >> +IMAKE_INSTALL=3D INSTALL=3D"install ${INSTALLFLAGS}" >=20 > This is a correct change, > ngie please explain exactly why this is an exception to = INSTALL?=3Dinstall. There are edge cases I=E2=80=99ve had to work around in the = build system in the past, where using $INSTALL would not work here, = e.g., use =E2=80=9CINSTALL=3Dtrue=E2=80=9D. This would break that use. There=E2=80=99s also absolutely no guarantee that =E2=80=9C$INSTAL= L=E2=80=9D knows how to interpret "$INSTALLFLAGS=E2=80=9D; FreeBSD=E2=80=99= s install(1) however, used during make distribution, installworld, = installkernel, etc, does support these flags. The same goes for mtree as well; nmtree isn=E2=80=99t the same = as the older version of mtree that=E2=80=99s on older (pre-9.x) systems = (IIRC). It=E2=80=99s better to use known build/install tools to avoid = maintenance/debugging burden. Thanks, -Enji=