From owner-freebsd-ports@FreeBSD.ORG Mon Feb 21 09:50:12 2005 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C71A316A4CE; Mon, 21 Feb 2005 09:50:12 +0000 (GMT) Received: from heechee.tobez.org (heechee.tobez.org [217.157.39.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 170E743D1D; Mon, 21 Feb 2005 09:50:11 +0000 (GMT) (envelope-from tobez@tobez.org) Received: by heechee.tobez.org (Postfix, from userid 1001) id DEAC1125465; Mon, 21 Feb 2005 10:50:09 +0100 (CET) Date: Mon, 21 Feb 2005 10:50:09 +0100 From: Anton Berezin To: Brian Fundakowski Feldman Message-ID: <20050221095009.GB60998@heechee.tobez.org> Mail-Followup-To: Anton Berezin , Brian Fundakowski Feldman , ports@FreeBSD.org References: <20050217204306.GA1116@green.homeunix.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050217204306.GA1116@green.homeunix.org> User-Agent: Mutt/1.4.2.1i X-Powered-By: FreeBSD http://www.freebsd.org/ cc: ports@FreeBSD.org Subject: Re: portsperf (bsd.port.mk performance bugs fixed) redux X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2005 09:50:12 -0000 On Thu, Feb 17, 2005 at 03:59:13PM -0500, Brian Fundakowski Feldman wrote: > Well, guys, it's been a while since the last installment of portsperf. > Without further ado, here's a fix that bring port vulnerability check > time down from almost two minutes to almost instantaneous (on my > machine)! I was always wondering why ports have been so terribly slow > since around some time last year, and a good 2000 pids get recycled > just doing "make extract": > <@green_> now: > <@green_> green# time make extract > <@green_> ===> Extracting for mp3gain-1.3.2 > <@green_> => Checksum OK for mp3gain132_src.zip. > <@green_> ===> mp3gain-1.3.2 depends on executable: unzip - found > <@green_> 0.127u 1.132s 0:01.49 83.8% 108+497k 15+0io 8pf+0w > > <@green_> then: > <@green_> green# time make extract > <@green_> ===> Extracting for mp3gain-1.3.2 > <@green_> => Checksum OK for mp3gain132_src.zip. > <@green_> ===> mp3gain-1.3.2 depends on executable: unzip - found > <@green_> 5.308u 82.765s 1:42.05 86.2% 92+193k 10+0io 12pf+0w > Index: bsd.port.mk > =================================================================== > RCS file: /usr/ncvs/ports/Mk/bsd.port.mk,v > retrieving revision 1.509 > diff -u -r1.509 bsd.port.mk > --- bsd.port.mk 9 Feb 2005 09:07:37 -0000 1.509 > +++ bsd.port.mk 17 Feb 2005 20:37:17 -0000 > @@ -3009,14 +3009,18 @@ > if [ "$$audit_created" -lt "$$audit_expiry" ]; then \ > ${ECHO_MSG} "===> WARNING: Vulnerability database out of date, checking anyway"; \ > fi; \ > - vlist=`${_EXTRACT_AUDITFILE} | ${GREP} "${PORTNAME}" | \ > - ${AWK} -F\| ' /^[^#]/ { \ Are you sure that the "then" part in your test was done with bsd.port.mk that contains this `${GREP} "${PORTNAME}"' snippet, and not before it was added? It is a recent addition, and it serves exactly the purpose of speeding up vulnerabilities checking. root@hrum audio/mp3gain# time make extract ===> Extracting for mp3gain-1.3.2 => Checksum OK for mp3gain132_src.zip. ===> mp3gain-1.3.2 depends on executable: unzip - found make extract 0.14s user 0.11s system 100% cpu 0.249 total Recent stock bsd.port.mk, portaudit installed and enabled. Cheers, \Anton. -- The moronity of the universe is a monotonically increasing function. -- Jarkko Hietaniemi