From owner-cvs-all Fri Dec 7 6:13:29 2001 Delivered-To: cvs-all@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id CCA3737B416; Fri, 7 Dec 2001 06:13:21 -0800 (PST) Received: by flood.ping.uio.no (Postfix, from userid 2602) id A502514C53; Fri, 7 Dec 2001 15:13:20 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Ruslan Ermilov Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Peter Wemm , Mark Murray , Bruce Evans Subject: Re: PAM, libssh, and all that (was: Re: cvs commit: src/lib/libpam/modules/pam_ssh pam_ssh.c) References: <200112071151.fB7BplS52145@freefall.freebsd.org> <20011207155257.A65808@sunbay.com> <20011207160554.C65808@sunbay.com> From: Dag-Erling Smorgrav Date: 07 Dec 2001 15:13:20 +0100 In-Reply-To: <20011207160554.C65808@sunbay.com> Message-ID: Lines: 40 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Ruslan Ermilov writes: > On Fri, Dec 07, 2001 at 02:59:46PM +0100, Dag-Erling Smorgrav wrote: > > Ruslan Ermilov writes: > > > On Fri, Dec 07, 2001 at 03:51:47AM -0800, Dag-Erling Smorgrav wrote: > > > > Log: > > > > Get pam_mod_misc.h from .CURDIR rather than .OBJDIR or /usr/include. > > > Um, why?! > > Because that's the way the other modules do it, and in some > > circumstances, pam_ssh won't build at all without this change. > Look, I asked "why". Please tell us your fellow developers why > this was needed. I fail to see the reason myself. Is it so hard? When building libpam separately (not as part of a world build), pam_ssh will incorrectly use the copy of pam_mod_misc.h from /usr/include instead of the one from the source tree. Since you have to build the modules before the library (because they're linked into the static library), if you introduce a non-backward-compatible change in pam_mod_misc.h or nuke /usr/include/security before building, pam_ssh won't build. All the other modules get this right by including "pam_mod_misc.h" instead of . An alternative fix would be to repocopy pam_mod_misc.h into src/lib/libpam/libpam/security and fix the Makefiles accordingly; all modules could then #include and get the right version of pam_mod_misc.h. This was my initial intention, but cvs@ asked me to change pam_ssh.c instead. > > > On a side note, with recent pam.d changes, something is seriously > > > screwed. I don't have USE_PAM_D setting in my make.conf(5), and > > > on a freshly build 5.0-CURRENT I hereby have an empty /etc/pam.d. > > > Every attempt to use su(1) results in: > > > [...] > > Already fixed. > Which commit fixed it, specifically? Revision 1.4 of pam_handlers.c. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message