From owner-freebsd-net@freebsd.org  Thu Apr 20 13:32:33 2017
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 451E9D482F6
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Thu, 20 Apr 2017 13:32:33 +0000 (UTC)
 (envelope-from srs0=haqt=34=sigsegv.be=kristof@codepro.be)
Received: from venus.codepro.be (venus.codepro.be [IPv6:2a01:4f8:162:1127::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits))
 (Client CN "*.codepro.be", Issuer "Gandi Standard SSL CA 2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 0FD4AEC3
 for <freebsd-net@freebsd.org>; Thu, 20 Apr 2017 13:32:33 +0000 (UTC)
 (envelope-from srs0=haqt=34=sigsegv.be=kristof@codepro.be)
Received: from [172.16.5.2] (vega.codepro.be [IPv6:2a01:4f8:162:1127::3])
 (Authenticated sender: kp)
 by venus.codepro.be (Postfix) with ESMTPSA id CFBDC96A1;
 Thu, 20 Apr 2017 15:32:30 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sigsegv.be; s=mail;
 t=1492695150; bh=V769rYNIuf3ziW+ETqxA5DJUPLaeQiDAQQxIv/pEFGE=;
 h=From:To:Cc:Subject:Date:In-Reply-To:References;
 b=HJGy5/A8qIe/IpajAIEjhVNgb9lmzG1oOMde0qQVgtY/zLns+cc5di2JMoqLLNDAV
 VKd2Zn+zXAaoIKzqLwJ4WTLDCP5YjywzW8LNdrnnY3skVqd3Ln1yyCyGKPyC/N9F83
 qGUb0iGe7ll3cpulszk7Z9OSEakksfP8fmz731B4=
From: "Kristof Provost" <kristof@sigsegv.be>
To: "Marko Zec" <zec@fer.hr>
Cc: freebsd-net@freebsd.org, peter.blok@bsd4all.org
Subject: Re: MFC VIMAGE fixes to 11-stable
Date: Thu, 20 Apr 2017 15:32:29 +0200
Message-ID: <ACA8734E-88DF-4E7F-BB54-00D393ED7EA6@sigsegv.be>
In-Reply-To: <20170420152853.019e5480@x23>
References: <8E6FC1CD-24D5-46D5-A6A1-760DD612F92D@bsd4all.org>
 <20170420124256.1190665d@x23>
 <60C3FBF7-7CF3-49AF-9DDF-0589AE9D9146@sigsegv.be>
 <20170420152853.019e5480@x23>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Mailer: MailMate (2.0BETAr6082)
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Apr 2017 13:32:33 -0000

On 20 Apr 2017, at 15:28, Marko Zec wrote:
> Right.  But pfi_attach_group_event() and the other handlers cited 
> above
> _do_ in fact invoke CURVNET_SET(vnet0) on entry, overriding the proper
> vnet choice from the caller.
>
Yes, that does look wrong.
I should have looked a bit further.

> Therefore the proper fix should be as simple as removing CURVNET_SET() 
> /
> CURVNET_RESTORE() macro pairs from the cited handlers.
>
Hopefully, yes. I’ve still got some other pf/vnet issues on my todo 
list, but
I’ve now added this too.  It might actually explain some other bug 
report I’ve
seen (but not looked at in any depth).

Regards,
Kristof