From owner-cvs-all Mon May 18 14:34:53 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id OAA09604 for cvs-all-outgoing; Mon, 18 May 1998 14:34:53 -0700 (PDT) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id OAA09469; Mon, 18 May 1998 14:34:13 -0700 (PDT) (envelope-from julian@whistle.com) Received: (from daemon@localhost) by alpo.whistle.com (8.8.5/8.8.5) id OAA19251; Mon, 18 May 1998 14:24:26 -0700 (PDT) Received: from current1.whistle.com(207.76.205.22) via SMTP by alpo.whistle.com, id smtpd019227; Mon May 18 21:24:18 1998 Date: Mon, 18 May 1998 14:24:12 -0700 (PDT) From: Julian Elischer To: Bruce Evans cc: guido@FreeBSD.ORG, jhay@mikom.csir.co.za, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet tcp_input.c In-Reply-To: <199805182054.GAA30065@godzilla.zeta.org.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Tue, 19 May 1998, Bruce Evans wrote: > >> guido 1998/05/18 10:07:59 PDT > >> > >> Modified files: > >> sys/netinet tcp_input.c > >> Log: > >> Add some parenthesis for clarity and fix a bug > >> Pointed out by: Garrett Wollmand > > ^ > >Shouldn't you also add this to rc.network so that it can start > >automatically on new machines? :-) > > Then you should also add the bd :-). It deletes parentheses for > clarity. Its review of this patch: "2 extra layers of parentheses > is 2 more layers than I would use and 1 more layer than KNF. This > change has no affect on the object code. Where is the bug fix?". > > [The change was from `(foo & BAR && ...' to (((foo & BAR) != 0) && ...'.] there may not have been a bug but it's a hell of a lot easier to read.. > > Bruce > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message