From owner-freebsd-arch@FreeBSD.ORG Thu Mar 13 14:26:29 2008 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 52B9C106566C for ; Thu, 13 Mar 2008 14:26:29 +0000 (UTC) (envelope-from cokane@freebsd.org) Received: from QMTA08.emeryville.ca.mail.comcast.net (qmta08.emeryville.ca.mail.comcast.net [76.96.30.80]) by mx1.freebsd.org (Postfix) with ESMTP id 24B058FC1E for ; Thu, 13 Mar 2008 14:26:29 +0000 (UTC) (envelope-from cokane@freebsd.org) Received: from OMTA03.emeryville.ca.mail.comcast.net ([76.96.30.27]) by QMTA08.emeryville.ca.mail.comcast.net with comcast id 0dTj1Z0040b6N64A804T00; Thu, 13 Mar 2008 14:15:46 +0000 Received: from discordia ([24.61.189.203]) by OMTA03.emeryville.ca.mail.comcast.net with comcast id 0eGG1Z0074PktZC8P00000; Thu, 13 Mar 2008 14:16:17 +0000 X-Authority-Analysis: v=1.0 c=1 a=yWIViUiLWPYA:10 a=c5sTgUsrrxMA:10 a=pW49DAFhvdKtc-utfFoA:9 a=pMymjJw0Sgto9zC7YjIuad9EabMA:4 a=zUBsD6tbDSsA:10 Received: by discordia (Postfix, from userid 103) id 2870B1636F9; Thu, 13 Mar 2008 10:16:16 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.1.8-gr1 (2007-02-13) on discordia X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.8-gr1 Received: from [172.20.1.3] (erwin.int.cokane.org [172.20.1.3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by discordia (Postfix) with ESMTP id C8ABE1636F8; Thu, 13 Mar 2008 10:16:02 -0400 (EDT) Message-ID: <47D93656.2000203@FreeBSD.org> Date: Thu, 13 Mar 2008 10:12:38 -0400 From: Coleman Kane Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.12 (X11/20080312) MIME-Version: 1.0 To: John Baldwin , freebsd-arch@freebsd.org References: <47D7C25D.5070908@cokane.org> <200803120945.29018.jhb@freebsd.org> <47D7E5BF.2060102@cokane.org> <200803121058.04096.jhb@freebsd.org> In-Reply-To: <200803121058.04096.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: imp@FreeBSD.org, obrien@FreeBSD.org Subject: Re: SMPTODO: remove timeout(9) from ffs_softdep.c X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: cokane@FreeBSD.org List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Mar 2008 14:26:29 -0000 John Baldwin wrote: > On Wednesday 12 March 2008 10:16:31 am Coleman Kane wrote: > >> I am attaching the revised patch. >> > > Looks good. I would perhaps not add the extra {}'s around the single-line if > clauses as it slightly obfuscates the diff (style(9) actually suggests no > {}'s in that case, but I think in practice our sources have a mixture of > both). > I'm going to commit the attached patch to ffs_softdep.c this afternoon (EDT) if there aren't any objections. Thanks for the thrice-over guys, you've been very helpful. -- Coleman Kane