From owner-dev-commits-src-main@freebsd.org Sat Jan 23 07:30:06 2021
Return-Path: <owner-dev-commits-src-main@freebsd.org>
Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
by mailman.nyi.freebsd.org (Postfix) with ESMTP id 738D94E971A;
Sat, 23 Jan 2021 07:30:06 +0000 (UTC)
(envelope-from antoine.brodin.freebsd@gmail.com)
Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com
[209.85.218.45])
(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
client-signature RSA-PSS (2048 bits) client-digest SHA256)
(Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
by mx1.freebsd.org (Postfix) with ESMTPS id 4DN77f2mWBz3MCY;
Sat, 23 Jan 2021 07:30:06 +0000 (UTC)
(envelope-from antoine.brodin.freebsd@gmail.com)
Received: by mail-ej1-f45.google.com with SMTP id g3so10881239ejb.6;
Fri, 22 Jan 2021 23:30:06 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=AT6MVikYEolNt5Ceuv/gRSeenkcudHV0xoXOD9a6QY0=;
b=je0Ethib72HqbjuEHMDeaKiM44gHCP6TrtXol1yuiMozXCJeBQgIA8Y6Leo8O7HCqN
z0dUs9QKG/hKkj8mdwdg79gDjElgqqVLgSKnt9sHnndunHNugtb4bI3ONMlXSnnoQxau
91UWCdU8bLtOTtAF0GIVG0axIYqhe2K2tF9G3QeOLZsR56LSHOg7b9y16HiepIVlmSx/
lN5Aom4KF1N0e6l904oMOTvZD2JxA4MX5D2Bhhbg/WieuDUf4IicuUxDyMbVdKiQoR4A
/Al/8my52ZQAIUNUpOjiLVTNy6KI337gkWL6g277t0J26NhmXcmxzc7WwUPGzaxvjBmp
omEw==
X-Gm-Message-State: AOAM531SEasEKEj/waO5+3aGuGJpq2Jzi/gW883uliIs7ZCn/jYEbgx/
/9nbjqJaEWw+Vf0DMtS6XQ1nUYDiUkzuwmkNUxCeFHx/YUE=
X-Google-Smtp-Source: ABdhPJxY+TBEBUW0SrZF8f4m+fipd9PpIAvHFt9/Uas2qjxM9kwMuGZRd5bA5nXJDc4Ur/Ii2AvVUiwk+yq6bx4LK18=
X-Received: by 2002:a17:906:478a:: with SMTP id
cw10mr5239594ejc.533.1611387004580;
Fri, 22 Jan 2021 23:30:04 -0800 (PST)
MIME-Version: 1.0
References: <202101221940.10MJeTcd061452@gitrepo.freebsd.org>
In-Reply-To: <202101221940.10MJeTcd061452@gitrepo.freebsd.org>
From: Antoine Brodin <antoine@freebsd.org>
Date: Sat, 23 Jan 2021 08:29:55 +0100
Message-ID: <CAALwa8nscmUwAANWK2TBdzkay9DuhFSuNfZPKEBwefWwo2JhMg@mail.gmail.com>
Subject: Re: git: 86f33b5fcf60 - main - elfctl: allow features to be specified
by value
To: Ed Maste <emaste@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>,
dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-Rspamd-Queue-Id: 4DN77f2mWBz3MCY
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
none
X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[];
TAGGED_FROM(0.00)[]
X-BeenThere: dev-commits-src-main@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for the main branch of the src repository
<dev-commits-src-main.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-main>,
<mailto:dev-commits-src-main-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-main/>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Help: <mailto:dev-commits-src-main-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main>,
<mailto:dev-commits-src-main-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Jan 2021 07:30:06 -0000
On Fri, Jan 22, 2021 at 8:40 PM Ed Maste <emaste@freebsd.org> wrote:
>
> The branch main has been updated by emaste:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=86f33b5fcf6087bf4439881011b920ff99e6e300
>
> commit 86f33b5fcf6087bf4439881011b920ff99e6e300
> Author: Ed Maste <emaste@FreeBSD.org>
> AuthorDate: 2021-01-22 17:22:35 +0000
> Commit: Ed Maste <emaste@FreeBSD.org>
> CommitDate: 2021-01-22 19:38:52 +0000
>
> elfctl: allow features to be specified by value
>
> This will allow elfctl on older releases to set bits that are not yet
> known there, so that the binary will have the correct settings applied
> if run on a later FreeBSD version.
>
> PR: 252629 (related)
> Suggested by: kib
> Reviewed by: gbe (manpage, earlier), kib
> MFC after: 3 days
> Sponsored by: The FreeBSD Foundation
> Differential Revision: https://reviews.freebsd.org/D28284
This fails to build:
--- all_subdir_usr.bin ---
--- all_subdir_usr.bin/elfctl ---
/usr/local/poudriere/jails/main-i386/usr/src/usr.bin/elfctl/elfctl.c:258:18:
error: comparison of integers of different signs: 'long' and 'unsigned
int' [-Werror,-Wsign-compare]
--- all_subdir_lib ---
--- powitf2.po ---
--- all_subdir_usr.bin ---
else if (val > UINT_MAX)
~~~ ^ ~~~~~~~~
--- all_subdir_lib ---
Antoine