From owner-cvs-all Fri Dec 14 8:46: 4 2001 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id D71E237B416; Fri, 14 Dec 2001 08:45:48 -0800 (PST) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.6/8.11.2) id fBEGjWU07191; Fri, 14 Dec 2001 18:45:32 +0200 (EET) (envelope-from ru) Date: Fri, 14 Dec 2001 18:45:32 +0200 From: Ruslan Ermilov To: Luigi Rizzo Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/rm rm.c src/usr.sbin/chown chown.c src/usr.sbin/dev_mkdb dev_mkdb.c Message-ID: <20011214184532.A99179@sunbay.com> References: <200112141622.fBEGMg705939@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200112141622.fBEGMg705939@freefall.freebsd.org> User-Agent: Mutt/1.3.23i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Dec 14, 2001 at 08:22:42AM -0800, Luigi Rizzo wrote: > luigi 2001/12/14 08:22:42 PST > > Modified files: > bin/rm rm.c > usr.sbin/chown chown.c > usr.sbin/dev_mkdb dev_mkdb.c > Log: > Add prototypes for main() so that these programs compile with -Werror > (which somehow now seems to be the default for compiling -current). > This error popped up while doing a PicoBSD cross-compile on a 4.3-ish system, > it may well be that there are other apps which have similar problems, > but I did not spot them as they are not included in my picobsd config. > > Whether adding prototypes for main() is the correct solution or not > I have no idea, a request to -current on the matter went basically > unanswered. Those who have better ideas are welcome to back this out > and replace it with the correct fix. > > Revision Changes Path > 1.34 +2 -1 src/bin/rm/rm.c > 1.20 +2 -1 src/usr.sbin/chown/chown.c > 1.6 +1 -0 src/usr.sbin/dev_mkdb/dev_mkdb.c > Luigi, Now everybody knows that you don't actually use -CURRENT. :-) In -CURRENT, main() doesn't require a prototype. Please back these out. Cherrs, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message