From owner-freebsd-arm@FreeBSD.ORG Mon Dec 16 21:50:45 2013 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 31D1FE6D for ; Mon, 16 Dec 2013 21:50:45 +0000 (UTC) Received: from mail-ie0-f182.google.com (mail-ie0-f182.google.com [209.85.223.182]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id EDD5C114D for ; Mon, 16 Dec 2013 21:50:44 +0000 (UTC) Received: by mail-ie0-f182.google.com with SMTP id as1so7379964iec.13 for ; Mon, 16 Dec 2013 13:50:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=wCCOgto1GCNuPI/rP3bUEIHhlStsELdOrrXt45I369Y=; b=CilfRxXivpUuSVFwdtrIDDKWCSSIE6Mb3NOlXBEQsfUrU71ak/dgN45z/SOSbsK0s/ UoggqQygwDOkTuuBixV+I8bxIv+BKJDWImj20Hqoer+4jNIoYhUKlu3xarDnbVH6s8RH K9W3Z8zT/I1XlHRHHP4uq3Rvk3Ns6MjMvI6DcKM2n4vxY0KgkqRj6YtlmtAO3++3XQUS WESFJiCOc4RbQtxsTFQ2tyDV+4FgoI/7+fyx8ioPFGhMyBkrWTepBue88eTca5SdqVqa IA2e36HNw4WCc01mMb4tgmYk09zDBLxhMarEIrfSoxtvF5Gbl+FHfwSAms/UqUnpJ3oQ 0cdw== X-Gm-Message-State: ALoCoQmaIsiEvlEnsI7Lk+8YVZbWflJVrihpY3Z/dOeITuRWMWVJUqDKoCptV/gA0XhZS3vPWaVq X-Received: by 10.50.108.235 with SMTP id hn11mr227535igb.0.1387230638696; Mon, 16 Dec 2013 13:50:38 -0800 (PST) Received: from fusion-mac.bsdimp.com (50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198]) by mx.google.com with ESMTPSA id l7sm18522408igx.2.2013.12.16.13.50.37 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 16 Dec 2013 13:50:37 -0800 (PST) Sender: Warner Losh Subject: Re: RFC: ARM related fixes - GIC, cache line size, PCI FDT & AHCI Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <52AF3D06.2000004@semihalf.com> Date: Mon, 16 Dec 2013 14:50:36 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <52AF3D06.2000004@semihalf.com> To: Zbigniew Bodek X-Mailer: Apple Mail (2.1085) Cc: "freebsd-arm@freebsd.org" , br@freebsd.org, Olivier Houchard X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Dec 2013 21:50:45 -0000 On Dec 16, 2013, at 10:48 AM, Zbigniew Bodek wrote: > Hello Everyone. >=20 > We would like to submit some new patches recently developed by = Semihalf. Thanks for your efforts here. Would there be a need to MFC these patches = to 10 and/or 9? > You can find them here: > http://people.freebsd.org/~zbb/Semihalf/12.2013/ >=20 > Detailed description is available in the commit logs but in general: >=20 > -- 0001-Resolve-cache-line-size-using-CP15.patch > - use cache line size acquired in runtime This looks good (assuming the register definitions are good, I didn't = verify them). Might be useful to publish these values to userland = somehow, maybe via a sysctl. This is option, but would be nice to have. Would also be good to have USB_ALIGN kassert if using USB and this value = is < that macro. Do other, older CPUs need similar decoding, or are the hard-wired values = good? > -- 0002-GIC-polarity-and-level-support.patch > - suport for setting trigger level and polarity in GIC This one seems to be OK, but is complicated enough that more eyeballs = and testing would be good.... > -- 0003-Add-PCI-FDT-interrupt-trigger-polarity-parsing.patch > - trigger and polarity parsing for PCI FDT interrupts This patch might conflict. + if (trig) + *trig =3D tmp_trig; + if (pol) + *pol =3D tmp_pol; Are not zero values also valid? > -- 0004-Do-not-attach-to-bridges-in-AHCI-driver.patch I'd add the word 'PCI' before bridge in the comment, otherwise this = looks good. > -- 0005-Use-only-mapped-BIOs-on-ARM.patch A comment about what MVA is would be useful.. Otherwise does what it = says. > - Two patches enabling the AHCI driver on ARM chips I didn't see these. Did I miss something? Or is the unmapped stuff all = it takes? > We will appreciate if you could post your comments and/or remarks by = the > end of this week when we plan to commit the changes. >=20 > Best regards > zbb > _______________________________________________ > freebsd-arm@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-arm > To unsubscribe, send any mail to "freebsd-arm-unsubscribe@freebsd.org"