From owner-cvs-all@FreeBSD.ORG  Thu Jan 15 10:11:55 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6952716A4D0
	for <cvs-all@FreeBSD.org>; Thu, 15 Jan 2004 10:11:55 -0800 (PST)
Received: from root.org (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id C9D6043D48
	for <cvs-all@FreeBSD.org>; Thu, 15 Jan 2004 10:11:52 -0800 (PST)
	(envelope-from nate@root.org)
Received: (qmail 71589 invoked by uid 1000); 15 Jan 2004 18:11:53 -0000
Date: Thu, 15 Jan 2004 10:11:53 -0800 (PST)
From: Nate Lawson <nate@root.org>
To: Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?= <des@des.no>
In-Reply-To: <xzpwu7tignh.fsf@dwp.des.no>
Message-ID: <20040115101021.L71463@root.org>
References: <200401151015.i0FAF49u009868@repoman.freebsd.org>
	<xzpwu7tignh.fsf@dwp.des.no>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern init_main.c kern_descrip.c sys_pipe.c
 uipc_syscalls.c uipc_usrreq.c vfs_syscalls.c src/sys/sys filedesc.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Jan 2004 18:11:55 -0000

On Thu, 15 Jan 2004, Dag-Erling [iso-8859-1] Sm=F8rgrav wrote:
> Tim Robbins <tjr@freebsd.org> writes:
> > Thanks for committing this. I'm interested, though, what was the reason=
 you
> > changed it to use a single bitmap instead of two levels?
>
> The increased complexity didn't actually translate into a performance
> improvement.  There was no reason to use two levels instead of one.
> The theoretical advantage is logarithmic rather than linear early
> growth, but in practice it wasn't noticeable.  The cost of the logic
> required to maintain and use the high-level bitmap outweighs the gain
> (which is to save a handful of comparisons against zero in the
> low-level bitmap).

A related question, why wasn't sys/bitstring.h used?

-Nate