From owner-svn-src-all@freebsd.org Thu Jun 22 18:34:23 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B7D38D923BE; Thu, 22 Jun 2017 18:34:23 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 731E7B1A; Thu, 22 Jun 2017 18:34:23 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io0-x22c.google.com with SMTP id j24so870088ioi.3; Thu, 22 Jun 2017 11:34:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=+YtcHOSAN/zjmeJCcgOhuYpVDBmCyBzbYuo6ZVqLVEM=; b=cOOkN+3ViukQxYeMpnFzpPc5MwMtNUgB2DsIlKDtC3HVtON0Yrt4ai0AMdE9PCgjQ9 y8h7Za/D5L/4E+/Wb4us81CX+Q2C5yTBZgsqbMVsNzq99yD7UNxghqP1L1CXuO4txzmR XZ+5H+H5HampxcdyltAm0SVUZ6YT9Fm5bw3OYlvMxaJOTZVyPMWLgAz751KF9TD0ikom kzVOPVw5+J50XejskxJUzjFwbbBXo18OC/u4os64mC9bYQB+2TrQYl3CKnll/+k6tTJd /Xx9xzd5iFE1h1BKSXzv5ruoIqWRQP8evRaGTJ9I6G/rvs7fqh9n7Rtf63f8YkexCLky cYvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=+YtcHOSAN/zjmeJCcgOhuYpVDBmCyBzbYuo6ZVqLVEM=; b=sz3xHLpK/cvHbSBYi9+7rG+cpsTpCZdDMAE9WPQajN57zEmiBMadsdy0SnZEcBBc5z ja74YuqDNEPUlrlgD6XKI+D9CSXasK703i72iseUZQOrbfTcYjtUlun0jytArb5qysaJ MsASES0r7PBPjX9e21PjOWarUbT6Bxi/zqS2rrNpL36pMpsfal+5UiYSbufgcqhNA7aL Sr9qT65lCuX4a4sB3LMDar2yW0M5iEpTQGfLu+XI+6HVewExiruj/v/zQgLzlreCnvNE 9JAE1eWTrJXevp0RzIck5KQhYbt4UlV2bU6pliUtJpnpUV4hfn2ti2PXw3xYKWE7hRdt H5AA== X-Gm-Message-State: AKS2vOwrPCZlwmG54OjWHYvEE/i7TVPY41YBZyOM7JYrCemQZRtaWTlx R11epWXOVCBkCM7MoVJE2iyX87teooZ2 X-Received: by 10.107.59.211 with SMTP id i202mr3520811ioa.159.1498156462681; Thu, 22 Jun 2017 11:34:22 -0700 (PDT) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.10.85 with HTTP; Thu, 22 Jun 2017 11:34:02 -0700 (PDT) In-Reply-To: <1F8C5886-71FC-486B-9793-E3554843CC65@FreeBSD.org> References: <201706221430.v5MEU9Zc063375@repo.freebsd.org> <1F8C5886-71FC-486B-9793-E3554843CC65@FreeBSD.org> From: Ed Maste Date: Thu, 22 Jun 2017 14:34:02 -0400 X-Google-Sender-Auth: kShrHdim_e3ZPwwjU-ASMKDpaZ4 Message-ID: Subject: Re: svn commit: r320234 - head/sys/boot/efi/include To: Dimitry Andric Cc: src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jun 2017 18:34:23 -0000 On 22 June 2017 at 14:23, Dimitry Andric wrote: >> Modified: head/sys/boot/efi/include/efidef.h >> ============================================================================== >> --- head/sys/boot/efi/include/efidef.h Thu Jun 22 13:31:44 2017 (r320233) >> +++ head/sys/boot/efi/include/efidef.h Thu Jun 22 14:30:09 2017 (r320234) >> @@ -178,6 +178,7 @@ typedef enum { >> #define EFI_MEMORY_DESCRIPTOR_VERSION 1 >> typedef struct { >> UINT32 Type; // Field size is 32 bits followed by 32 bit pad >> + UINT32 Pad; >> EFI_PHYSICAL_ADDRESS PhysicalStart; // Field size is 64 bits >> EFI_VIRTUAL_ADDRESS VirtualStart; // Field size is 64 bits >> UINT64 NumberOfPages; // Field size is 64 bits > > If you explicitly insert padding, it is better to mark the struct as > __packed, I think. Or at least also specify the alignment explicitly. Perhaps, although this struct now matches the definition in the edk and u-boot EFI headers.