From owner-svn-src-head@freebsd.org Sun Mar 1 21:25:45 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E11E724E6DD; Sun, 1 Mar 2020 21:25:45 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48VxCD0dYSz4D3D; Sun, 1 Mar 2020 21:25:43 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qk1-x744.google.com with SMTP id p62so5543748qkb.0; Sun, 01 Mar 2020 13:25:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4rL2QP/EfFgR9rSwEwTKa284KgKHwHCOEGFSe4rlJn4=; b=PHqtntCl4tt7kW5nkd9owRzJiYFSt0/tI8z04vgqcbQfrx3XNTBad3QpCPGKQaGnWu TFHR5f2hz0ndEmqVeYQ9LFLEKpoB8m258qeEAYbAl0N7/kKjX4Wv+8EWDMF0uIlcRxHK BjorC556ampAPm/AitG3UgRGF3/cA1O0bBNEtEVsFpTcESqHs0crIAnFwlsk9O3hqVZ7 HKwr6NF7Z22enwEu2ikijCkdmP+uR4wnRKnPVlDKNEk/nxeEJ++4e+hIk2OynVtJ1Wnj Tk1hrtpB98LZ0ujapTANErMcf+AkA5kydr9VHyBDJ0opC7h13QQVuUjURKwO4O3u5jxb CDqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=4rL2QP/EfFgR9rSwEwTKa284KgKHwHCOEGFSe4rlJn4=; b=ELzKmlGBjv8jMck5eeRniGdBIrLtyj54nABqovxDgXCbLrvqb5kkUkC02Jx0diIAxF xf+G6SiatdsChtqNPX9CleohYoiqWjyE6/R9KYZNAGXfzGuBpFD+ho/6kDkv31UwS7V3 I+PYHVMrGQpICKAMzmH9XAuYPcsJktovtoaUJ4hu0n7k8VFYnZQkpD9Hh4pJXjQ/bbyR bkncSKICAHFER8665Ta+U16c8u/0mGUS8wX9uUgtBN4RQENR40sl4wJ0vsYgquPpSiAK /zemuHo5xYvyhalTvg8ONfWOLZg9GKFBle1swafxqxgTKpS3uP2stvCAGkfRzE/Zn8xu YFCQ== X-Gm-Message-State: APjAAAV+SO4rXAX9xNPAV/GEwzMnleRgYNO5zdVS+0IWmdGTC1tOriZg NuYxHFugXzhoW+26ADRSjchLdpdc X-Google-Smtp-Source: APXvYqy/cSOuOsNtbrCjeArmcMgvI8S4iTODRjpHaX9gdw033FYVMQtOHQga9bVrCf8d295uInBtiA== X-Received: by 2002:a37:a8c3:: with SMTP id r186mr13176613qke.37.1583097943057; Sun, 01 Mar 2020 13:25:43 -0800 (PST) Received: from raichu (toroon0560w-lp130-11-70-50-21-248.dsl.bell.ca. [70.50.21.248]) by smtp.gmail.com with ESMTPSA id u49sm7846859qtj.42.2020.03.01.13.25.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2020 13:25:42 -0800 (PST) Sender: Mark Johnston Date: Sun, 1 Mar 2020 16:25:37 -0500 From: Mark Johnston To: Emmanuel Vadot Cc: Jeff Roberson , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Jan Beich Subject: Re: svn commit: r358363 - head/sys/vm Message-ID: <20200301212537.GA33873@raichu> References: <202002270237.01R2bRLJ023799@repo.freebsd.org> <20200229212411.1e6aed2d49d6644937b78452@bidouilliste.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200229212411.1e6aed2d49d6644937b78452@bidouilliste.com> X-Rspamd-Queue-Id: 48VxCD0dYSz4D3D X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=PHqtntCl; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::744 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-2.08 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-0.99)[-0.994,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[4.4.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-0.39)[ip: (1.63), ipnet: 2607:f8b0::/32(-1.88), asn: 15169(-1.67), country: US(-0.05)]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Mar 2020 21:25:46 -0000 On Sat, Feb 29, 2020 at 09:24:11PM +0100, Emmanuel Vadot wrote: > > Hi Jeff, > > On Thu, 27 Feb 2020 02:37:27 +0000 (UTC) > Jeff Roberson wrote: > > > Author: jeff > > Date: Thu Feb 27 02:37:27 2020 > > New Revision: 358363 > > URL: https://svnweb.freebsd.org/changeset/base/358363 > > > > Log: > > Add unlocked grab* function variants that use lockless radix code to > > lookup pages. These variants will fall back to their locked counterparts > > if the page is not present. > > > > Discussed with: kib, markj > > Differential Revision: https://reviews.freebsd.org/D23449 > > > > Modified: > > head/sys/vm/vm_page.c > > head/sys/vm/vm_page.h > > > > We're (jbeich@ and me) seeing wired memory leak since this commit. > A simple way to reproduce is to have drm-kmod (either 4.16 or 5.0) and > liba-intel-driver/libva-intel-media-driver and start mpv in a loop : > > while mpv --hwdec=vaapi --start=10.0 --end=10.1 /path/to/file ; do > done > > Reverting this commit on one of my test machine shows that this is the > culprit. > If you need anymore info/debug let me know. > > Thanks. Could you give this patch a try? diff --git a/sys/vm/vm_page.c b/sys/vm/vm_page.c index 9d50881ed27e..41e7a5bb3099 100644 --- a/sys/vm/vm_page.c +++ b/sys/vm/vm_page.c @@ -4535,7 +4535,8 @@ vm_page_grab_valid(vm_page_t *mp, vm_object_t object, vm_pindex_t pindex, int al (VM_ALLOC_NOWAIT | VM_ALLOC_WAITFAIL | VM_ALLOC_ZERO)) == 0, ("vm_page_grab_valid: Invalid flags 0x%X", allocflags)); VM_OBJECT_ASSERT_WLOCKED(object); - pflags = allocflags & ~(VM_ALLOC_NOBUSY | VM_ALLOC_SBUSY); + pflags = allocflags & ~(VM_ALLOC_NOBUSY | VM_ALLOC_SBUSY | + VM_ALLOC_WIRED); pflags |= VM_ALLOC_WAITFAIL; retrylookup: